From f7413ecbfbe787e070bfe95016df8d5542996d91 Mon Sep 17 00:00:00 2001 From: Lennart Jern Date: Fri, 30 Jun 2023 14:58:01 +0300 Subject: [PATCH] Set M3M concurrency to 1 and add warning We currently have an issue with concurrency when associating a BMH to a M3M. A mutex was already added before to the Associate function. However, this does not completely solve the issue, because a caching client is used. In other words, the next M3M to associate can sometimes use cached data about the BMHs and pick one that is already associated. --- main.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/main.go b/main.go index 2603c87a2..ccadce7de 100644 --- a/main.go +++ b/main.go @@ -266,8 +266,8 @@ func initFlags(fs *pflag.FlagSet) { "The address the health endpoint binds to.", ) - fs.IntVar(&metal3MachineConcurrency, "metal3machine-concurrency", 10, - "Number of metal3machines to process simultaneously") + fs.IntVar(&metal3MachineConcurrency, "metal3machine-concurrency", 1, + "Number of metal3machines to process simultaneously. WARNING! Currently not safe to set > 1.") fs.IntVar(&metal3ClusterConcurrency, "metal3cluster-concurrency", 10, "Number of metal3clusters to process simultaneously")