Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get PDF support working again #153

Closed
transitive-bullshit opened this issue Oct 21, 2021 · 4 comments
Closed

Get PDF support working again #153

transitive-bullshit opened this issue Oct 21, 2021 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@transitive-bullshit
Copy link
Member

There are numerous build issues with react-pdf and Next.js.

See wojtekmaj/react-pdf#136 and wojtekmaj/react-pdf#874 for the two main ones I'm running into.

I've decided to remove react-pdf from react-notion-x for now until these issues are sorted.

@AnshumanFauzdar
Copy link

Instead of leaving blank some coming soon graphics can be displayed otherwise it is plain and confusing for beginners :)
image

@herohoro
Copy link

herohoro commented Feb 2, 2022

We look forward to PDF support.(´;ω;`)

@transitive-bullshit
Copy link
Member Author

This should be working again as of v4.19.0.

I also added an example of how to use pdfs: https://github.com/NotionX/react-notion-x/blob/master/examples/full/components/NotionPage.tsx#L31

@herohoro
Copy link

Thank you very much. I will update it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants