Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default NuGet config sources path on CoreCLR #472

Closed
ChengTian opened this issue Apr 21, 2015 · 3 comments
Closed

Fix default NuGet config sources path on CoreCLR #472

ChengTian opened this issue Apr 21, 2015 · 3 comments
Assignees
@zhili1208
Labels
Functionality:SDK The NuGet client packages published to nuget.org Platform:Xplat Priority:2 Issues for the current backlog. Type:Bug
Milestone
3.4 Beta

Comments

@ChengTian
Copy link

The current path we use to create default NuGet config sources is wrong.

We should use local application data folder it. @davidfowl found a good way to get the path from environment variable. See https://github.com/mono/mono/blob/master/mcs/class/corlib/System/Environment.cs#L653.

See current code: https://github.com/NuGet/NuGet.Configuration/blob/dev/src/NuGet.Configuration/PackageSource/PackageSourceProvider.cs#L68-L78
@yishaigalatzer
Copy link

We can use the environment variable LOCALAPPDATA and fallback if its empty to XDG_DATA_HOME mono style.

@johnataylor johnataylor added Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Type:Bug labels Apr 23, 2015
@johnataylor johnataylor added this to the 3.0.0-RTM milestone Apr 23, 2015
@deepakaravindr deepakaravindr mentioned this issue Apr 30, 2015
Closed
@BrennanConroy BrennanConroy mentioned this issue May 6, 2015
Closed
7 tasks
@ChengTian ChengTian mentioned this issue May 7, 2015
Closed
@yishaigalatzer yishaigalatzer modified the milestones: 3.1.0-Beta, 3.0.0-RTM Jun 11, 2015
@yishaigalatzer yishaigalatzer assigned feiling and unassigned ChengTian Nov 25, 2015
@yishaigalatzer yishaigalatzer modified the milestones: 3.4, 3.3.0 Nov 25, 2015
@yishaigalatzer
Copy link

We think this is fixed already, please verify and close

@zhili1208
Copy link
Contributor

it's fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhili1208 zhili1208

Labels
Functionality:SDK The NuGet client packages published to nuget.org Platform:Xplat Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Milestone
3.4 Beta
Development

No branches or pull requests
6 participants
@yishaigalatzer @ChengTian @johnataylor @feiling @emgarten @zhili1208