Block package reference to tool package type when there is no property to indicate the project is a temporary project to restore the package

[wli3]

Tools CLI ask

tool package can reference normal package

tool package can reference tool package

normal package cannot reference tool package

rid split requires

 mytool
 (
identity package, tool package) -> win-x64.mytool (rid specific package, a tool package)
                                         
                                         ->linux-x64.mytool (rid specific package, a tool package) 
                                   
                                          -> Microsoft.NETCore.Platform (a normal package to provide rid relation)

[nkolev92]

Due to the way we do compat checking and performance considerations, we will be doing the follwoing:

ToolPackage cannot be found in the normal project graph (only in the special project graph).
Top level dependencies of DotnetToolReference projects HAVE to be of DotnetTool type!

So in theory a package can reference a tool project, but it will never be restoreable.
In addition, people would have to do crazy workarounds to build a package like this.

[bricelam]

ToolPackage cannot be found in the normal project graph

I'm arguing semantics here, but shouldn't this be: Only Dependency packages are allowed

[nkolev92]

Closed in NuGet/NuGet.Client#1900