Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements for NuGet assets location overriding via BaseIntermediateOutputPath and MsBuildExtensionsPath #6644

Closed
4 tasks
nkolev92 opened this issue Mar 7, 2018 · 1 comment
Closed
4 tasks

Enhancements for NuGet assets location overriding via BaseIntermediateOutputPath and MsBuildExtensionsPath #6644

nkolev92 opened this issue Mar 7, 2018 · 1 comment
Assignees
@nkolev92 @jainaashish
Labels
Priority:1 High priority issues that must be resolved in the current sprint. Style:PackageReference
Milestone
Backlog

Comments

@nkolev92
Copy link
Member

nkolev92 commented Mar 7, 2018 •
edited
Loading

  • We will consider a warning if MSBuildProjectsExtensionsPath and BaseIntermediateOutputPath are not equivalent. Consider non-NuGet restore scenarios (meaning only do it in PR potentially)

  • Consider an error if someone is building with RestoreOutputPath set (or using RestoreOutputPath in a restore for build). Consider how dotnet self-contained publish scenarios might affect this.

  • Change the UWP/csproj PR build tasks to reflect this.

  • Consider cross-versions complications (From the brainstorming me, the only sideeffect will be that the targets and props will now be imported, thus fixing a bug, and if someone is using cross-versions in their CI/VS, they'll get the assets file in an unexpected folder)
@nkolev92 nkolev92 added this to the Backlog milestone Mar 7, 2018
@nkolev92 nkolev92 added Priority:1 High priority issues that must be resolved in the current sprint. Area:Build Task Style:PackageReference labels Mar 7, 2018
@nkolev92 nkolev92 mentioned this issue Mar 7, 2018
Closed
@nkolev92
Copy link
Member Author

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

@jainaashish jainaashish

Labels
Priority:1 High priority issues that must be resolved in the current sprint. Style:PackageReference
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@nkolev92 @jainaashish