Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When doing a NoOp restore, avoid *.dgspec.json write in obj directory #7854

Closed
nkolev92 opened this issue Mar 6, 2019 · 1 comment
Closed

When doing a NoOp restore, avoid *.dgspec.json write in obj directory #7854

nkolev92 opened this issue Mar 6, 2019 · 1 comment
Assignees
@nkolev92
Labels
Functionality:Restore Type:Bug
Milestone
5.1

Comments

@nkolev92
Copy link
Member

nkolev92 commented Mar 6, 2019 •
edited
Loading

Found during the investigation of #7836 (comment).

The dgspec.json write does not have a dirty check.
Currently it's being overridden even during no-op scenarios where nothing has changed.

The issue was introduced in the original PR NuGet/NuGet.Client#2521
@nkolev92 nkolev92 added this to the 5.0 milestone Mar 6, 2019
@nkolev92 nkolev92 self-assigned this Mar 6, 2019
This was referenced Mar 6, 2019
Merged
Closed
@rrelyea rrelyea added CLI RTM and removed CLI RTM labels Apr 1, 2019
@rrelyea rrelyea changed the title Add a dirty check for the dgspec.json write When doing a NoOp restore, avoid obj\*dgspec.json write Apr 2, 2019
@rrelyea rrelyea changed the title When doing a NoOp restore, avoid obj\*dgspec.json write When doing a NoOp restore, avoid *.dgspec.json write in obj directory Apr 3, 2019
@nkolev92 nkolev92 mentioned this issue Apr 5, 2019
Closed
@nkolev92
Copy link
Member Author

nkolev92 commented Apr 5, 2019

This was actually not merged in 5.0.
It got punted to 5.1.

@nkolev92 nkolev92 modified the milestones: 5.0, 5.1 Apr 5, 2019
@rrelyea rrelyea removed the RTM label May 15, 2019
@mjcheetham mjcheetham mentioned this issue Oct 30, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Functionality:Restore Type:Bug
Projects
None yet
Milestone
5.1
Development

No branches or pull requests
2 participants
@nkolev92 @rrelyea