From 4b099aeb5fb5a0097e03031512677b0a24547bd4 Mon Sep 17 00:00:00 2001 From: Jeff Handley Date: Tue, 8 Apr 2014 14:45:01 -0700 Subject: [PATCH 01/20] Change the sort text based on if there's a term or not --- src/NuGetGallery/Views/Shared/ListPackages.cshtml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/NuGetGallery/Views/Shared/ListPackages.cshtml b/src/NuGetGallery/Views/Shared/ListPackages.cshtml index abb69c0384..be5ac125fe 100644 --- a/src/NuGetGallery/Views/Shared/ListPackages.cshtml +++ b/src/NuGetGallery/Views/Shared/ListPackages.cshtml @@ -1,6 +1,7 @@ @model PackageListViewModel @{ ViewBag.Title = String.IsNullOrWhiteSpace(Model.SearchTerm) ? "Packages" : "Packages matching " + Model.SearchTerm; + ViewBag.SortText = String.IsNullOrWhiteSpace(Model.SearchTerm) ? "recent installs" : "relevance"; ViewBag.Tab = "Packages"; } @@ -33,7 +34,7 @@ } -Sorted by Recent Installs +sorted by @ViewBag.SortText From 009ac183fc2e06c153fda4fcda42b0e1197466d8 Mon Sep 17 00:00:00 2001 From: anurse Date: Mon, 21 Apr 2014 13:10:22 -0700 Subject: [PATCH 15/20] Appease FxCop --- src/NuGetGallery/UrlExtensions.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/NuGetGallery/UrlExtensions.cs b/src/NuGetGallery/UrlExtensions.cs index f796e2dd14..5eb8a4c40e 100644 --- a/src/NuGetGallery/UrlExtensions.cs +++ b/src/NuGetGallery/UrlExtensions.cs @@ -1,4 +1,5 @@ using System; +using System.Globalization; using System.Web; using System.Web.Mvc; using System.Web.Routing; @@ -142,7 +143,7 @@ public static string ExplorerDeepLink(this UrlHelper url, int feedVersion, strin urlResult = EnsureTrailingSlash(urlResult); - return string.Format(PackageExplorerDeepLink, urlResult, id, version); + return String.Format(CultureInfo.InvariantCulture, PackageExplorerDeepLink, urlResult, id, version); } public static string LogOn(this UrlHelper url) From 6913d81bf573255c33fb46faf8e9f68da0b69b70 Mon Sep 17 00:00:00 2001 From: anurse Date: Tue, 22 Apr 2014 10:15:02 -0700 Subject: [PATCH 16/20] Fix #2070 by fixing up more T4MVC cruft :( --- src/NuGetGallery/App_Start/Routes.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/NuGetGallery/App_Start/Routes.cs b/src/NuGetGallery/App_Start/Routes.cs index 7728c6e6e4..7e165e42b8 100644 --- a/src/NuGetGallery/App_Start/Routes.cs +++ b/src/NuGetGallery/App_Start/Routes.cs @@ -315,12 +315,12 @@ public static void RegisterRoutes(RouteCollection routes) routes.MapRoute( "v2PackageIds", "api/v2/package-ids", - new { controller = "Api", action = "GetPackageIds" }); + new { controller = "Api", action = "PackageIDs" }); routes.MapRoute( "v2PackageVersions", "api/v2/package-versions/{id}", - new { controller = "Api", action = "GetPackageVersions" }); + new { controller = "Api", action = "PackageVersions" }); routes.MapRoute( RouteName.StatisticsDownloadsApi, From 6321a65aa5c1bbf1f5595ff012bf005c6987491a Mon Sep 17 00:00:00 2001 From: anurse Date: Tue, 22 Apr 2014 11:02:45 -0700 Subject: [PATCH 17/20] Fixed the JavaScript date format for good? I hope? --- src/NuGetGallery/ExtensionMethods.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/NuGetGallery/ExtensionMethods.cs b/src/NuGetGallery/ExtensionMethods.cs index 9e8eaf568c..efaf2ec15e 100644 --- a/src/NuGetGallery/ExtensionMethods.cs +++ b/src/NuGetGallery/ExtensionMethods.cs @@ -400,4 +400,4 @@ private static User LoadUser(IOwinContext context) return null; // No user logged in, or credentials could not be resolved } } -} \ No newline at end of file +} From c031ada2def2c41ce82c9212727483d511a945ad Mon Sep 17 00:00:00 2001 From: anurse Date: Tue, 22 Apr 2014 11:07:27 -0700 Subject: [PATCH 18/20] Fix #2008 for realz this time please! --- src/NuGetGallery/ExtensionMethods.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/NuGetGallery/ExtensionMethods.cs b/src/NuGetGallery/ExtensionMethods.cs index 0c9509a6db..efaf2ec15e 100644 --- a/src/NuGetGallery/ExtensionMethods.cs +++ b/src/NuGetGallery/ExtensionMethods.cs @@ -25,7 +25,7 @@ public static class ExtensionMethods { public static string ToJavaScriptUTC(this DateTime self) { - return self.ToString("yyyy-MM-dd HH:mm:ss UTC", CultureInfo.CurrentCulture); + return self.ToString("O", CultureInfo.CurrentCulture) + "Z"; } public static string ToNuGetShortDateTimeString(this DateTime self) From 3cc72e1c0ed61d9e2800ccb5450f72bae9c2af96 Mon Sep 17 00:00:00 2001 From: anurse Date: Tue, 22 Apr 2014 11:35:38 -0700 Subject: [PATCH 19/20] Fixed up the timestamp yet again --- src/NuGetGallery/ExtensionMethods.cs | 2 +- src/NuGetGallery/Infrastructure/ApplicationVersionHelper.cs | 3 ++- src/NuGetGallery/Views/Shared/ListPackages.cshtml | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/NuGetGallery/ExtensionMethods.cs b/src/NuGetGallery/ExtensionMethods.cs index efaf2ec15e..ce9f41565a 100644 --- a/src/NuGetGallery/ExtensionMethods.cs +++ b/src/NuGetGallery/ExtensionMethods.cs @@ -25,7 +25,7 @@ public static class ExtensionMethods { public static string ToJavaScriptUTC(this DateTime self) { - return self.ToString("O", CultureInfo.CurrentCulture) + "Z"; + return self.ToUniversalTime().ToString("O", CultureInfo.CurrentCulture); } public static string ToNuGetShortDateTimeString(this DateTime self) diff --git a/src/NuGetGallery/Infrastructure/ApplicationVersionHelper.cs b/src/NuGetGallery/Infrastructure/ApplicationVersionHelper.cs index 652188fe32..f3e86f2090 100644 --- a/src/NuGetGallery/Infrastructure/ApplicationVersionHelper.cs +++ b/src/NuGetGallery/Infrastructure/ApplicationVersionHelper.cs @@ -1,6 +1,7 @@ using System; using System.Collections.Generic; using System.Diagnostics.CodeAnalysis; +using System.Globalization; using System.Linq; using System.Reflection; using System.Web; @@ -99,7 +100,7 @@ private static ApplicationVersion LoadVersion() string repoUriString = TryGet(metadata, "RepositoryUrl"); DateTime buildDate; - if (!DateTime.TryParse(dateString, out buildDate)) + if (!DateTime.TryParse(dateString, CultureInfo.InvariantCulture, DateTimeStyles.AssumeUniversal, out buildDate)) { buildDate = DateTime.MinValue; } diff --git a/src/NuGetGallery/Views/Shared/ListPackages.cshtml b/src/NuGetGallery/Views/Shared/ListPackages.cshtml index 899740ac13..fbc262fdc0 100644 --- a/src/NuGetGallery/Views/Shared/ListPackages.cshtml +++ b/src/NuGetGallery/Views/Shared/ListPackages.cshtml @@ -33,9 +33,9 @@ {

Displaying results @Model.FirstResultIndex - @Model.LastResultIndex.

} - @if(Model.IndexTimestampUtc.HasValue) + @if(Model.IndexTimestampUtc.HasValue) { -

Search Index last updated

+

Search Index last updated

} From eddc0e53180cbce5df94f99bd982bf67c13afeee Mon Sep 17 00:00:00 2001 From: anurse Date: Tue, 22 Apr 2014 13:46:02 -0700 Subject: [PATCH 20/20] Fixed an off-by-one error :( --- src/NuGetGallery/Scripts/nugetgallery.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/NuGetGallery/Scripts/nugetgallery.js b/src/NuGetGallery/Scripts/nugetgallery.js index e5a9cce12d..87c1398f9c 100644 --- a/src/NuGetGallery/Scripts/nugetgallery.js +++ b/src/NuGetGallery/Scripts/nugetgallery.js @@ -101,7 +101,7 @@ } ampm = "PM"; } - $(this).text(utc.getFullYear() + "-" + padInt(utc.getMonth(), 2) + "-" + padInt(utc.getDate(), 2) + " " + hrs + ":" + padInt(utc.getMinutes(), 2) + " " + ampm + " Local Time"); + $(this).text(utc.getFullYear() + "-" + padInt(utc.getMonth() + 1, 2) + "-" + padInt(utc.getDate(), 2) + " " + hrs + ":" + padInt(utc.getMinutes(), 2) + " " + ampm + " Local Time"); }); $('time.timeago').timeago(); }