Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Improve sampling configuration for AI #3817

Closed
ryuyu opened this issue Apr 24, 2017 · 2 comments
Closed

[Search] Improve sampling configuration for AI #3817

ryuyu opened this issue Apr 24, 2017 · 2 comments
Assignees
@loic-sharma
Labels
Area: Monitoring & Alerting Area: Search Pillar: Monitoring Verified-Dev Verified-Prod
Milestone
S119 - 2017.5.30

Comments

@ryuyu
Copy link
Contributor

ryuyu commented Apr 24, 2017

The sampling logic that AI is using for the search service appears to be throttling and dropping events that should otherwise be reported.
@skofman1 skofman1 added this to the S118 - 2017.5.08 milestone May 1, 2017
@skofman1 skofman1 changed the title [NuGet.Services.Metadata]AI is missing events [Search] Improve sampling configuration for AI May 8, 2017
@skofman1
Copy link
Contributor

skofman1 commented May 8, 2017

We would like to continue sampling requests. Shouldn't sample traces, exceptions. Traces currently log every request. This is redundant. Should be removed.

@loic-sharma
Copy link
Contributor

Pull request here.

@loic-sharma loic-sharma mentioned this issue May 22, 2017
Merged
@shishirx34 shishirx34 mentioned this issue Jun 9, 2017
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loic-sharma loic-sharma

Labels
Area: Monitoring & Alerting Area: Search Pillar: Monitoring Verified-Dev Verified-Prod
Projects
None yet
Milestone
S119 - 2017.5.30
Development

No branches or pull requests
3 participants
@loic-sharma @ryuyu @skofman1