Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: step 13, remove ember-addon keyword during migration #19

Open
lifeart opened this issue Feb 19, 2022 · 1 comment
Open

Comments

@lifeart
Copy link
Contributor

lifeart commented Feb 19, 2022

According to https://github.com/embroider-build/embroider/blob/main/PORTING-ADDONS-TO-V2.md

In test-app/package.json, change the top-level "name" to "test-app", remove the "ember-addon" section, and remove "ember-addon" from keywords.

@NullVoxPopuli
Copy link
Owner

NullVoxPopuli commented Feb 24, 2022

test app does not contain keywords at all 🤔 do you have a reproduction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants