Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are @types/ember__test-helpers still necessary? #62

Open
nicolechung opened this issue Jun 1, 2023 · 1 comment
Open

Are @types/ember__test-helpers still necessary? #62

nicolechung opened this issue Jun 1, 2023 · 1 comment

Comments

@nicolechung
Copy link
Contributor

Screenshot 2023-06-01 at 7 29 09 PM

Asking because I'm getting this error:

TS2688: Cannot find type definition file for 'ember__test-helpers'.
       [js]   The file is in the program because:
       [js]     Entry point for implicit type library 'ember__test-helpers'

Does this mean this line can be removed?

"@types/ember__test-helpers": "^2.6.1",

@NullVoxPopuli
Copy link
Owner

NullVoxPopuli commented Jun 1, 2023

They are not! -- nice find!

@types/ember__test-helpers breaks type checking 🙈 --- ember-cli-typescript hasn't had a release since October.
So, anyone working with TS will want these changes in their blueprint / updates / migrations as well: https://github.com/typed-ember/ember-cli-typescript/pulls/@me

I think @simonihmig is working on updating the TS blueprint in ember-cli -- which will greatly help mitigate all the TS work-arounds everywhere -- in this repo, in the v2 addon blueprint, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants