Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge passing context by default #204

Merged
merged 4 commits into from
Jan 9, 2022
Merged

feat: merge passing context by default #204

merged 4 commits into from
Jan 9, 2022

Conversation

nightire
Copy link
Contributor

@nightire nightire commented Jan 5, 2022

BREAKING CHANGE

@nightire
Copy link
Contributor Author

nightire commented Jan 5, 2022

I added the failing test first, will try to implement later.

BTW, when I run yarn at first time, it triggers the prepare script which ultimatelly copy the README.md from the root to the ember-statechart-component folder, I didn't commit this change because I don't know if it is intentional, should I commit that as well?

@nightire nightire mentioned this pull request Jan 5, 2022
Closed
@NullVoxPopuli
Copy link
Owner

should I commit that as well?

nah, that's supposed to be gitignored -- or maybe it should be a symlink. idk

@NullVoxPopuli
Copy link
Owner

Lemme know if you need or want help ❤️

@nightire nightire marked this pull request as ready for review January 6, 2022 06:17
@nightire
Copy link
Contributor Author

nightire commented Jan 6, 2022 •
edited
Loading

Lemme know if you need or want help ❤️

@NullVoxPopuli It's just too late and I need to take a rest.😴 Now it's ready to review.

@NullVoxPopuli NullVoxPopuli merged commit 643a8c6 into NullVoxPopuli:main Jan 9, 2022
@NullVoxPopuli
Copy link
Owner

Thank you!

github-actions bot pushed a commit that referenced this pull request Jan 9, 2022
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
85d79f4 
# [4.0.0](v3.2.3...v4.0.0) (2022-01-09)

### Features

* merge context by default ([74d921c](74d921c))
* merge passing context by default ([643a8c6](643a8c6)), closes [#204](#204)

### BREAKING CHANGES

* context is now merged instead of replaced
@github-actions
Copy link

github-actions bot commented Jan 9, 2022

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nightire nightire deleted the context-merging branch January 9, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nightire @NullVoxPopuli