From e42d350bb505e45fbdd5adf546dafd55e0c4d8f7 Mon Sep 17 00:00:00 2001 From: Denis Roussel Date: Wed, 9 Oct 2024 10:46:33 +0200 Subject: [PATCH 1/3] [ADD] stock_picking_putaway_recompute --- .../addons/stock_picking_putaway_recompute | 1 + .../stock_picking_putaway_recompute/setup.py | 6 + stock_picking_putaway_recompute/README.rst | 117 +++++ stock_picking_putaway_recompute/__init__.py | 1 + .../__manifest__.py | 20 + .../models/__init__.py | 1 + .../models/stock_move_line.py | 48 ++ .../models/stock_picking.py | 38 ++ .../models/stock_picking_type.py | 14 + .../readme/CONFIGURE.md | 3 + .../readme/CONTEXT.md | 7 + .../readme/CONTRIBUTORS.md | 1 + .../readme/DESCRIPTION.md | 2 + .../readme/USAGE.md | 7 + .../static/description/icon.png | Bin 0 -> 9455 bytes .../static/description/index.html | 458 ++++++++++++++++++ .../tests/__init__.py | 0 .../tests/test_recompute_putaway.py | 217 +++++++++ .../views/stock_move_line.xml | 29 ++ .../views/stock_picking.xml | 29 ++ .../views/stock_picking_type.xml | 19 + 21 files changed, 1018 insertions(+) create mode 120000 setup/stock_picking_putaway_recompute/odoo/addons/stock_picking_putaway_recompute create mode 100644 setup/stock_picking_putaway_recompute/setup.py create mode 100644 stock_picking_putaway_recompute/README.rst create mode 100644 stock_picking_putaway_recompute/__init__.py create mode 100644 stock_picking_putaway_recompute/__manifest__.py create mode 100644 stock_picking_putaway_recompute/models/__init__.py create mode 100644 stock_picking_putaway_recompute/models/stock_move_line.py create mode 100644 stock_picking_putaway_recompute/models/stock_picking.py create mode 100644 stock_picking_putaway_recompute/models/stock_picking_type.py create mode 100644 stock_picking_putaway_recompute/readme/CONFIGURE.md create mode 100644 stock_picking_putaway_recompute/readme/CONTEXT.md create mode 100644 stock_picking_putaway_recompute/readme/CONTRIBUTORS.md create mode 100644 stock_picking_putaway_recompute/readme/DESCRIPTION.md create mode 100644 stock_picking_putaway_recompute/readme/USAGE.md create mode 100644 stock_picking_putaway_recompute/static/description/icon.png create mode 100644 stock_picking_putaway_recompute/static/description/index.html create mode 100644 stock_picking_putaway_recompute/tests/__init__.py create mode 100644 stock_picking_putaway_recompute/tests/test_recompute_putaway.py create mode 100644 stock_picking_putaway_recompute/views/stock_move_line.xml create mode 100644 stock_picking_putaway_recompute/views/stock_picking.xml create mode 100644 stock_picking_putaway_recompute/views/stock_picking_type.xml diff --git a/setup/stock_picking_putaway_recompute/odoo/addons/stock_picking_putaway_recompute b/setup/stock_picking_putaway_recompute/odoo/addons/stock_picking_putaway_recompute new file mode 120000 index 000000000000..e55af99f1e88 --- /dev/null +++ b/setup/stock_picking_putaway_recompute/odoo/addons/stock_picking_putaway_recompute @@ -0,0 +1 @@ +../../../../stock_picking_putaway_recompute \ No newline at end of file diff --git a/setup/stock_picking_putaway_recompute/setup.py b/setup/stock_picking_putaway_recompute/setup.py new file mode 100644 index 000000000000..28c57bb64031 --- /dev/null +++ b/setup/stock_picking_putaway_recompute/setup.py @@ -0,0 +1,6 @@ +import setuptools + +setuptools.setup( + setup_requires=['setuptools-odoo'], + odoo_addon=True, +) diff --git a/stock_picking_putaway_recompute/README.rst b/stock_picking_putaway_recompute/README.rst new file mode 100644 index 000000000000..a78e03cbc77a --- /dev/null +++ b/stock_picking_putaway_recompute/README.rst @@ -0,0 +1,117 @@ +=============================== +Stock Picking Putaway Recompute +=============================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:d732c5716c0c78265f37cdfbb2f846a45031a2dcb2792e8e3aca65a9df5c9ca3 + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistics--workflow-lightgray.png?logo=github + :target: https://github.com/OCA/stock-logistics-workflow/tree/16.0/stock_picking_putaway_recompute + :alt: OCA/stock-logistics-workflow +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_putaway_recompute + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-workflow&target_branch=16.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module will allow to recompute the destination locations from +putaway rules on the picking operations side. + +**Table of contents** + +.. contents:: + :local: + +Use Cases / Context +=================== + +As stock operations are computed at a certain moment of time, +configuration can change and the computed destination locations for +those operations (that are not done yet) are incoherent from those +configurations changes. + +So, the aim of this module is to provide a way to recompute the +destination locations without having to unreserve the picking (that +unlock products for being reserved for another picking). + +Configuration +============= + +- Enable Stock locations in Inventory > Configuration > Settings +- In order to be able to recompute the putaways, you need to enable it + on the picking type level. + +Usage +===== + +- In a picking where the recompute operation is enabled (see + Configuration), the recompute is available on picking level and on + the detailed operations if enabled. +- If a putaway rule has been changed after product reservation, click + on the button 'Recompute putaways'. This will recompute the + destination locations on all detailed operations that have no done + quantity yet. +- Moreover, the action is available on picking level and on detailed + operation one too. + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* ACSONE SA/NV + +Contributors +------------ + +- Denis Roussel denis.roussel@acsone.eu + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +.. |maintainer-rousseldenis| image:: https://github.com/rousseldenis.png?size=40px + :target: https://github.com/rousseldenis + :alt: rousseldenis + +Current `maintainer `__: + +|maintainer-rousseldenis| + +This module is part of the `OCA/stock-logistics-workflow `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/stock_picking_putaway_recompute/__init__.py b/stock_picking_putaway_recompute/__init__.py new file mode 100644 index 000000000000..0650744f6bc6 --- /dev/null +++ b/stock_picking_putaway_recompute/__init__.py @@ -0,0 +1 @@ +from . import models diff --git a/stock_picking_putaway_recompute/__manifest__.py b/stock_picking_putaway_recompute/__manifest__.py new file mode 100644 index 000000000000..bcb863b412e1 --- /dev/null +++ b/stock_picking_putaway_recompute/__manifest__.py @@ -0,0 +1,20 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +{ + "name": "Stock Picking Putaway Recompute", + "summary": """ + This module allows to recompute the picking operations putaways if + configurations have changed""", + "version": "16.0.1.0.0", + "license": "AGPL-3", + "author": "ACSONE SA/NV,Odoo Community Association (OCA)", + "website": "https://github.com/OCA/stock-logistics-workflow", + "maintainers": ["rousseldenis"], + "depends": ["stock"], + "data": [ + "views/stock_picking.xml", + "views/stock_picking_type.xml", + "views/stock_move_line.xml", + ], +} diff --git a/stock_picking_putaway_recompute/models/__init__.py b/stock_picking_putaway_recompute/models/__init__.py new file mode 100644 index 000000000000..7b81345ee018 --- /dev/null +++ b/stock_picking_putaway_recompute/models/__init__.py @@ -0,0 +1 @@ +from . import stock_move_line, stock_picking, stock_picking_type diff --git a/stock_picking_putaway_recompute/models/stock_move_line.py b/stock_picking_putaway_recompute/models/stock_move_line.py new file mode 100644 index 000000000000..22b74ef7bf65 --- /dev/null +++ b/stock_picking_putaway_recompute/models/stock_move_line.py @@ -0,0 +1,48 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +from __future__ import annotations + +from typing_extensions import Self + +from odoo import api, fields, models + + +class StockMoveLine(models.Model): + + _inherit = "stock.move.line" + + can_recompute_putaways = fields.Boolean( + compute="_compute_can_recompute_putaways", + ) + + @api.depends( + "picking_type_id.allow_to_recompute_putaways", "picking_id.printed", "qty_done" + ) + def _compute_can_recompute_putaways(self): + can_recompute_lines = self._filtered_for_putaway_recompute() + can_recompute_lines.can_recompute_putaways = True + (self - can_recompute_lines).can_recompute_putaways = False + + def _filtered_for_putaway_recompute(self) -> Self: + """ + Recompute putaways on operations that: + + - have their picking type configured for that + - have their picking not printed (started) + - have their qty_done field != 0 + """ + return self.filtered( + lambda line: line.picking_type_id.allow_to_recompute_putaways + and not line.picking_id.printed + and not line.qty_done + ) + + def _recompute_putaways(self) -> None: + """ + Launches the computation of putaways on operations that are + allowed to. + """ + self._filtered_for_putaway_recompute()._apply_putaway_strategy() + + def action_recompute_putaways(self): + self._recompute_putaways() diff --git a/stock_picking_putaway_recompute/models/stock_picking.py b/stock_picking_putaway_recompute/models/stock_picking.py new file mode 100644 index 000000000000..abc91f9c1545 --- /dev/null +++ b/stock_picking_putaway_recompute/models/stock_picking.py @@ -0,0 +1,38 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +from __future__ import annotations + +from typing_extensions import Self + +from odoo import api, fields, models + + +class StockPicking(models.Model): + + _inherit = "stock.picking" + + can_recompute_putaways = fields.Boolean( + compute="_compute_can_recompute_putaways", + help="Technical field in order to display the Recompute Putaways button.", + ) + + def action_recompute_putaways(self) -> dict: + """ + Launches the putaways recomputation on operations + """ + for picking in self: + picking.move_line_ids._recompute_putaways() + + def _filtered_can_recompute_putaways(self) -> Self: + """ + Filter current recordset in order to get the pickings that can + """ + return self.filtered( + lambda picking: picking.state == "assigned" and not picking.printed + ) + + @api.depends("state", "printed") + def _compute_can_recompute_putaways(self): + can_recompute_pickings = self._filtered_can_recompute_putaways() + can_recompute_pickings.can_recompute_putaways = True + (self - can_recompute_pickings).can_recompute_putaways = False diff --git a/stock_picking_putaway_recompute/models/stock_picking_type.py b/stock_picking_putaway_recompute/models/stock_picking_type.py new file mode 100644 index 000000000000..2d6ba82fd200 --- /dev/null +++ b/stock_picking_putaway_recompute/models/stock_picking_type.py @@ -0,0 +1,14 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import fields, models + + +class StockPickingType(models.Model): + + _inherit = "stock.picking.type" + + allow_to_recompute_putaways = fields.Boolean( + help="Check this if you want to authorize putaways recomputations for the operations" + "of this type." + ) diff --git a/stock_picking_putaway_recompute/readme/CONFIGURE.md b/stock_picking_putaway_recompute/readme/CONFIGURE.md new file mode 100644 index 000000000000..5a3b79e51aba --- /dev/null +++ b/stock_picking_putaway_recompute/readme/CONFIGURE.md @@ -0,0 +1,3 @@ +- Enable Stock locations in Inventory > Configuration > Settings +- In order to be able to recompute the putaways, you need to enable it on + the picking type level. diff --git a/stock_picking_putaway_recompute/readme/CONTEXT.md b/stock_picking_putaway_recompute/readme/CONTEXT.md new file mode 100644 index 000000000000..0cb687ec04dd --- /dev/null +++ b/stock_picking_putaway_recompute/readme/CONTEXT.md @@ -0,0 +1,7 @@ +As stock operations are computed at a certain moment of time, configuration +can change and the computed destination locations for those operations (that +are not done yet) are incoherent from those configurations changes. + +So, the aim of this module is to provide a way to recompute the destination locations +without having to unreserve the picking (that unlock products for being reserved for +another picking). diff --git a/stock_picking_putaway_recompute/readme/CONTRIBUTORS.md b/stock_picking_putaway_recompute/readme/CONTRIBUTORS.md new file mode 100644 index 000000000000..4e7e6847269e --- /dev/null +++ b/stock_picking_putaway_recompute/readme/CONTRIBUTORS.md @@ -0,0 +1 @@ +- Denis Roussel diff --git a/stock_picking_putaway_recompute/readme/DESCRIPTION.md b/stock_picking_putaway_recompute/readme/DESCRIPTION.md new file mode 100644 index 000000000000..a2265a04142f --- /dev/null +++ b/stock_picking_putaway_recompute/readme/DESCRIPTION.md @@ -0,0 +1,2 @@ +This module will allow to recompute the destination locations from putaway rules +on the picking operations side. diff --git a/stock_picking_putaway_recompute/readme/USAGE.md b/stock_picking_putaway_recompute/readme/USAGE.md new file mode 100644 index 000000000000..2a92f2d3174e --- /dev/null +++ b/stock_picking_putaway_recompute/readme/USAGE.md @@ -0,0 +1,7 @@ +- In a picking where the recompute operation is enabled (see Configuration), + the recompute is available on picking level and on the detailed operations if + enabled. +- If a putaway rule has been changed after product reservation, click on + the button 'Recompute putaways'. This will recompute the destination locations + on all detailed operations that have no done quantity yet. +- Moreover, the action is available on picking level and on detailed operation one too. diff --git a/stock_picking_putaway_recompute/static/description/icon.png b/stock_picking_putaway_recompute/static/description/icon.png new file mode 100644 index 0000000000000000000000000000000000000000..3a0328b516c4980e8e44cdb63fd945757ddd132d GIT binary patch literal 9455 zcmW++2RxMjAAjx~&dlBk9S+%}OXg)AGE&Cb*&}d0jUxM@u(PQx^-s)697TX`ehR4?GS^qbkof1cslKgkU)h65qZ9Oc=ml_0temigYLJfnz{IDzUf>bGs4N!v3=Z3jMq&A#7%rM5eQ#dc?k~! zVpnB`o+K7|Al`Q_U;eD$B zfJtP*jH`siUq~{KE)`jP2|#TUEFGRryE2`i0**z#*^6~AI|YzIWy$Cu#CSLW3q=GA z6`?GZymC;dCPk~rBS%eCb`5OLr;RUZ;D`}um=H)BfVIq%7VhiMr)_#G0N#zrNH|__ zc+blN2UAB0=617@>_u;MPHN;P;N#YoE=)R#i$k_`UAA>WWCcEVMh~L_ zj--gtp&|K1#58Yz*AHCTMziU1Jzt_jG0I@qAOHsk$2}yTmVkBp_eHuY$A9)>P6o~I z%aQ?!(GqeQ-Y+b0I(m9pwgi(IIZZzsbMv+9w{PFtd_<_(LA~0H(xz{=FhLB@(1&qHA5EJw1>>=%q2f&^X>IQ{!GJ4e9U z&KlB)z(84HmNgm2hg2C0>WM{E(DdPr+EeU_N@57;PC2&DmGFW_9kP&%?X4}+xWi)( z;)z%wI5>D4a*5XwD)P--sPkoY(a~WBw;E~AW`Yue4kFa^LM3X`8x|}ZUeMnqr}>kH zG%WWW>3ml$Yez?i%)2pbKPI7?5o?hydokgQyZsNEr{a|mLdt;X2TX(#B1j35xPnPW z*bMSSOauW>o;*=kO8ojw91VX!qoOQb)zHJ!odWB}d+*K?#sY_jqPdg{Sm2HdYzdEx zOGVPhVRTGPtv0o}RfVP;Nd(|CB)I;*t&QO8h zFfekr30S!-LHmV_Su-W+rEwYXJ^;6&3|L$mMC8*bQptyOo9;>Qb9Q9`ySe3%V$A*9 zeKEe+b0{#KWGp$F+tga)0RtI)nhMa-K@JS}2krK~n8vJ=Ngm?R!9G<~RyuU0d?nz# z-5EK$o(!F?hmX*2Yt6+coY`6jGbb7tF#6nHA zuKk=GGJ;ZwON1iAfG$E#Y7MnZVmrY|j0eVI(DN_MNFJmyZ|;w4tf@=CCDZ#5N_0K= z$;R~bbk?}TpfDjfB&aiQ$VA}s?P}xPERJG{kxk5~R`iRS(SK5d+Xs9swCozZISbnS zk!)I0>t=A<-^z(cmSFz3=jZ23u13X><0b)P)^1T_))Kr`e!-pb#q&J*Q`p+B6la%C zuVl&0duN<;uOsB3%T9Fp8t{ED108<+W(nOZd?gDnfNBC3>M8WE61$So|P zVvqH0SNtDTcsUdzaMDpT=Ty0pDHHNL@Z0w$Y`XO z2M-_r1S+GaH%pz#Uy0*w$Vdl=X=rQXEzO}d6J^R6zjM1u&c9vYLvLp?W7w(?np9x1 zE_0JSAJCPB%i7p*Wvg)pn5T`8k3-uR?*NT|J`eS#_#54p>!p(mLDvmc-3o0mX*mp_ zN*AeS<>#^-{S%W<*mz^!X$w_2dHWpcJ6^j64qFBft-o}o_Vx80o0>}Du;>kLts;$8 zC`7q$QI(dKYG`Wa8#wl@V4jVWBRGQ@1dr-hstpQL)Tl+aqVpGpbSfN>5i&QMXfiZ> zaA?T1VGe?rpQ@;+pkrVdd{klI&jVS@I5_iz!=UMpTsa~mBga?1r}aRBm1WS;TT*s0f0lY=JBl66Upy)-k4J}lh=P^8(SXk~0xW=T9v*B|gzIhN z>qsO7dFd~mgxAy4V?&)=5ieYq?zi?ZEoj)&2o)RLy=@hbCRcfT5jigwtQGE{L*8<@Yd{zg;CsL5mvzfDY}P-wos_6PfprFVaeqNE%h zKZhLtcQld;ZD+>=nqN~>GvROfueSzJD&BE*}XfU|H&(FssBqY=hPCt`d zH?@s2>I(|;fcW&YM6#V#!kUIP8$Nkdh0A(bEVj``-AAyYgwY~jB zT|I7Bf@%;7aL7Wf4dZ%VqF$eiaC38OV6oy3Z#TER2G+fOCd9Iaoy6aLYbPTN{XRPz z;U!V|vBf%H!}52L2gH_+j;`bTcQRXB+y9onc^wLm5wi3-Be}U>k_u>2Eg$=k!(l@I zcCg+flakT2Nej3i0yn+g+}%NYb?ta;R?(g5SnwsQ49U8Wng8d|{B+lyRcEDvR3+`O{zfmrmvFrL6acVP%yG98X zo&+VBg@px@i)%o?dG(`T;n*$S5*rnyiR#=wW}}GsAcfyQpE|>a{=$Hjg=-*_K;UtD z#z-)AXwSRY?OPefw^iI+ z)AXz#PfEjlwTes|_{sB?4(O@fg0AJ^g8gP}ex9Ucf*@_^J(s_5jJV}c)s$`Myn|Kd z$6>}#q^n{4vN@+Os$m7KV+`}c%4)4pv@06af4-x5#wj!KKb%caK{A&Y#Rfs z-po?Dcb1({W=6FKIUirH&(yg=*6aLCekcKwyfK^JN5{wcA3nhO(o}SK#!CINhI`-I z1)6&n7O&ZmyFMuNwvEic#IiOAwNkR=u5it{B9n2sAJV5pNhar=j5`*N!Na;c7g!l$ z3aYBqUkqqTJ=Re-;)s!EOeij=7SQZ3Hq}ZRds%IM*PtM$wV z@;rlc*NRK7i3y5BETSKuumEN`Xu_8GP1Ri=OKQ$@I^ko8>H6)4rjiG5{VBM>B|%`&&s^)jS|-_95&yc=GqjNo{zFkw%%HHhS~e=s zD#sfS+-?*t|J!+ozP6KvtOl!R)@@-z24}`9{QaVLD^9VCSR2b`b!KC#o;Ki<+wXB6 zx3&O0LOWcg4&rv4QG0)4yb}7BFSEg~=IR5#ZRj8kg}dS7_V&^%#Do==#`u zpy6{ox?jWuR(;pg+f@mT>#HGWHAJRRDDDv~@(IDw&R>9643kK#HN`!1vBJHnC+RM&yIh8{gG2q zA%e*U3|N0XSRa~oX-3EAneep)@{h2vvd3Xvy$7og(sayr@95+e6~Xvi1tUqnIxoIH zVWo*OwYElb#uyW{Imam6f2rGbjR!Y3`#gPqkv57dB6K^wRGxc9B(t|aYDGS=m$&S!NmCtrMMaUg(c zc2qC=2Z`EEFMW-me5B)24AqF*bV5Dr-M5ig(l-WPS%CgaPzs6p_gnCIvTJ=Y<6!gT zVt@AfYCzjjsMEGi=rDQHo0yc;HqoRNnNFeWZgcm?f;cp(6CNylj36DoL(?TS7eU#+ z7&mfr#y))+CJOXQKUMZ7QIdS9@#-}7y2K1{8)cCt0~-X0O!O?Qx#E4Og+;A2SjalQ zs7r?qn0H044=sDN$SRG$arw~n=+T_DNdSrarmu)V6@|?1-ZB#hRn`uilTGPJ@fqEy zGt(f0B+^JDP&f=r{#Y_wi#AVDf-y!RIXU^0jXsFpf>=Ji*TeqSY!H~AMbJdCGLhC) zn7Rx+sXw6uYj;WRYrLd^5IZq@6JI1C^YkgnedZEYy<&4(z%Q$5yv#Boo{AH8n$a zhb4Y3PWdr269&?V%uI$xMcUrMzl=;w<_nm*qr=c3Rl@i5wWB;e-`t7D&c-mcQl7x! zZWB`UGcw=Y2=}~wzrfLx=uet<;m3~=8I~ZRuzvMQUQdr+yTV|ATf1Uuomr__nDf=X zZ3WYJtHp_ri(}SQAPjv+Y+0=fH4krOP@S&=zZ-t1jW1o@}z;xk8 z(Nz1co&El^HK^NrhVHa-_;&88vTU>_J33=%{if;BEY*J#1n59=07jrGQ#IP>@u#3A z;!q+E1Rj3ZJ+!4bq9F8PXJ@yMgZL;>&gYA0%_Kbi8?S=XGM~dnQZQ!yBSgcZhY96H zrWnU;k)qy`rX&&xlDyA%(a1Hhi5CWkmg(`Gb%m(HKi-7Z!LKGRP_B8@`7&hdDy5n= z`OIxqxiVfX@OX1p(mQu>0Ai*v_cTMiw4qRt3~NBvr9oBy0)r>w3p~V0SCm=An6@3n)>@z!|o-$HvDK z|3D2ZMJkLE5loMKl6R^ez@Zz%S$&mbeoqH5`Bb){Ei21q&VP)hWS2tjShfFtGE+$z zzCR$P#uktu+#!w)cX!lWN1XU%K-r=s{|j?)Akf@q#3b#{6cZCuJ~gCxuMXRmI$nGtnH+-h z+GEi!*X=AP<|fG`1>MBdTb?28JYc=fGvAi2I<$B(rs$;eoJCyR6_bc~p!XR@O-+sD z=eH`-ye})I5ic1eL~TDmtfJ|8`0VJ*Yr=hNCd)G1p2MMz4C3^Mj?7;!w|Ly%JqmuW zlIEW^Ft%z?*|fpXda>Jr^1noFZEwFgVV%|*XhH@acv8rdGxeEX{M$(vG{Zw+x(ei@ zmfXb22}8-?Fi`vo-YVrTH*C?a8%M=Hv9MqVH7H^J$KsD?>!SFZ;ZsvnHr_gn=7acz z#W?0eCdVhVMWN12VV^$>WlQ?f;P^{(&pYTops|btm6aj>_Uz+hqpGwB)vWp0Cf5y< zft8-je~nn?W11plq}N)4A{l8I7$!ks_x$PXW-2XaRFswX_BnF{R#6YIwMhAgd5F9X zGmwdadS6(a^fjHtXg8=l?Rc0Sm%hk6E9!5cLVloEy4eh(=FwgP`)~I^5~pBEWo+F6 zSf2ncyMurJN91#cJTy_u8Y}@%!bq1RkGC~-bV@SXRd4F{R-*V`bS+6;W5vZ(&+I<9$;-V|eNfLa5n-6% z2(}&uGRF;p92eS*sE*oR$@pexaqr*meB)VhmIg@h{uzkk$9~qh#cHhw#>O%)b@+(| z^IQgqzuj~Sk(J;swEM-3TrJAPCq9k^^^`q{IItKBRXYe}e0Tdr=Huf7da3$l4PdpwWDop%^}n;dD#K4s#DYA8SHZ z&1!riV4W4R7R#C))JH1~axJ)RYnM$$lIR%6fIVA@zV{XVyx}C+a-Dt8Y9M)^KU0+H zR4IUb2CJ{Hg>CuaXtD50jB(_Tcx=Z$^WYu2u5kubqmwp%drJ6 z?Fo40g!Qd<-l=TQxqHEOuPX0;^z7iX?Ke^a%XT<13TA^5`4Xcw6D@Ur&VT&CUe0d} z1GjOVF1^L@>O)l@?bD~$wzgf(nxX1OGD8fEV?TdJcZc2KoUe|oP1#=$$7ee|xbY)A zDZq+cuTpc(fFdj^=!;{k03C69lMQ(|>uhRfRu%+!k&YOi-3|1QKB z z?n?eq1XP>p-IM$Z^C;2L3itnbJZAip*Zo0aw2bs8@(s^~*8T9go!%dHcAz2lM;`yp zD=7&xjFV$S&5uDaiScyD?B-i1ze`+CoRtz`Wn+Zl&#s4&}MO{@N!ufrzjG$B79)Y2d3tBk&)TxUTw@QS0TEL_?njX|@vq?Uz(nBFK5Pq7*xj#u*R&i|?7+6# z+|r_n#SW&LXhtheZdah{ZVoqwyT{D>MC3nkFF#N)xLi{p7J1jXlmVeb;cP5?e(=f# zuT7fvjSbjS781v?7{)-X3*?>tq?)Yd)~|1{BDS(pqC zC}~H#WXlkUW*H5CDOo<)#x7%RY)A;ShGhI5s*#cRDA8YgqG(HeKDx+#(ZQ?386dv! zlXCO)w91~Vw4AmOcATuV653fa9R$fyK8ul%rG z-wfS zihugoZyr38Im?Zuh6@RcF~t1anQu7>#lPpb#}4cOA!EM11`%f*07RqOVkmX{p~KJ9 z^zP;K#|)$`^Rb{rnHGH{~>1(fawV0*Z#)}M`m8-?ZJV<+e}s9wE# z)l&az?w^5{)`S(%MRzxdNqrs1n*-=jS^_jqE*5XDrA0+VE`5^*p3CuM<&dZEeCjoz zR;uu_H9ZPZV|fQq`Cyw4nscrVwi!fE6ciMmX$!_hN7uF;jjKG)d2@aC4ropY)8etW=xJvni)8eHi`H$%#zn^WJ5NLc-rqk|u&&4Z6fD_m&JfSI1Bvb?b<*n&sfl0^t z=HnmRl`XrFvMKB%9}>PaA`m-fK6a0(8=qPkWS5bb4=v?XcWi&hRY?O5HdulRi4?fN zlsJ*N-0Qw+Yic@s0(2uy%F@ib;GjXt01Fmx5XbRo6+n|pP(&nodMoap^z{~q ziEeaUT@Mxe3vJSfI6?uLND(CNr=#^W<1b}jzW58bIfyWTDle$mmS(|x-0|2UlX+9k zQ^EX7Nw}?EzVoBfT(-LT|=9N@^hcn-_p&sqG z&*oVs2JSU+N4ZD`FhCAWaS;>|wH2G*Id|?pa#@>tyxX`+4HyIArWDvVrX)2WAOQff z0qyHu&-S@i^MS-+j--!pr4fPBj~_8({~e1bfcl0wI1kaoN>mJL6KUPQm5N7lB(ui1 zE-o%kq)&djzWJ}ob<-GfDlkB;F31j-VHKvQUGQ3sp`CwyGJk_i!y^sD0fqC@$9|jO zOqN!r!8-p==F@ZVP=U$qSpY(gQ0)59P1&t@y?5rvg<}E+GB}26NYPp4f2YFQrQtot5mn3wu_qprZ=>Ig-$ zbW26Ws~IgY>}^5w`vTB(G`PTZaDiGBo5o(tp)qli|NeV( z@H_=R8V39rt5J5YB2Ky?4eJJ#b`_iBe2ot~6%7mLt5t8Vwi^Jy7|jWXqa3amOIoRb zOr}WVFP--DsS`1WpN%~)t3R!arKF^Q$e12KEqU36AWwnCBICpH4XCsfnyrHr>$I$4 z!DpKX$OKLWarN7nv@!uIA+~RNO)l$$w}p(;b>mx8pwYvu;dD_unryX_NhT8*Tj>BTrTTL&!?O+%Rv;b?B??gSzdp?6Uug9{ zd@V08Z$BdI?fpoCS$)t4mg4rT8Q_I}h`0d-vYZ^|dOB*Q^S|xqTV*vIg?@fVFSmMpaw0qtTRbx} z({Pg?#{2`sc9)M5N$*N|4;^t$+QP?#mov zGVC@I*lBVrOU-%2y!7%)fAKjpEFsgQc4{amtiHb95KQEwvf<(3T<9-Zm$xIew#P22 zc2Ix|App^>v6(3L_MCU0d3W##AB0M~3D00EWoKZqsJYT(#@w$Y_H7G22M~ApVFTRHMI_3be)Lkn#0F*V8Pq zc}`Cjy$bE;FJ6H7p=0y#R>`}-m4(0F>%@P|?7fx{=R^uFdISRnZ2W_xQhD{YuR3t< z{6yxu=4~JkeA;|(J6_nv#>Nvs&FuLA&PW^he@t(UwFFE8)|a!R{`E`K`i^ZnyE4$k z;(749Ix|oi$c3QbEJ3b~D_kQsPz~fIUKym($a_7dJ?o+40*OLl^{=&oq$<#Q(yyrp z{J-FAniyAw9tPbe&IhQ|a`DqFTVQGQ&Gq3!C2==4x{6EJwiPZ8zub-iXoUtkJiG{} zPaR&}_fn8_z~(=;5lD-aPWD3z8PZS@AaUiomF!G8I}Mf>e~0g#BelA-5#`cj;O5>N Xviia!U7SGha1wx#SCgwmn*{w2TRX*I literal 0 HcmV?d00001 diff --git a/stock_picking_putaway_recompute/static/description/index.html b/stock_picking_putaway_recompute/static/description/index.html new file mode 100644 index 000000000000..b9e9d767ff93 --- /dev/null +++ b/stock_picking_putaway_recompute/static/description/index.html @@ -0,0 +1,458 @@ + + + + + +Stock Picking Putaway Recompute + + + +
+

Stock Picking Putaway Recompute

+ + +

Beta License: AGPL-3 OCA/stock-logistics-workflow Translate me on Weblate Try me on Runboat

+

This module will allow to recompute the destination locations from +putaway rules on the picking operations side.

+

Table of contents

+ +
+

Use Cases / Context

+

As stock operations are computed at a certain moment of time, +configuration can change and the computed destination locations for +those operations (that are not done yet) are incoherent from those +configurations changes.

+

So, the aim of this module is to provide a way to recompute the +destination locations without having to unreserve the picking (that +unlock products for being reserved for another picking).

+
+
+

Configuration

+
    +
  • Enable Stock locations in Inventory > Configuration > Settings
    • +
  • In order to be able to recompute the putaways, you need to enable it +on the picking type level.
    • +
+
+
+

Usage

+
    +
  • In a picking where the recompute operation is enabled (see +Configuration), the recompute is available on picking level and on +the detailed operations if enabled.
    • +
  • If a putaway rule has been changed after product reservation, click +on the button ‘Recompute putaways’. This will recompute the +destination locations on all detailed operations that have no done +quantity yet.
    • +
  • Moreover, the action is available on picking level and on detailed +operation one too.
    • +
+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • ACSONE SA/NV
    • +
+
+
+

Contributors

+ +
+
+

Maintainers

+

This module is maintained by the OCA.

+Odoo Community Association +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

Current maintainer:

+

rousseldenis

+

This module is part of the OCA/stock-logistics-workflow project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + diff --git a/stock_picking_putaway_recompute/tests/__init__.py b/stock_picking_putaway_recompute/tests/__init__.py new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/stock_picking_putaway_recompute/tests/test_recompute_putaway.py b/stock_picking_putaway_recompute/tests/test_recompute_putaway.py new file mode 100644 index 000000000000..095a2c38c124 --- /dev/null +++ b/stock_picking_putaway_recompute/tests/test_recompute_putaway.py @@ -0,0 +1,217 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +from odoo.fields import Command + +from odoo.addons.base.tests.common import BaseCommon + + +class TestRecomputePutaway(BaseCommon): + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.rule_obj = cls.env["stock.putaway.rule"] + cls.location_obj = cls.env["stock.location"] + cls.suppliers = cls.env.ref("stock.stock_location_suppliers") + cls.stock = cls.env.ref("stock.stock_location_stock") + cls.type_in = cls.env.ref("stock.picking_type_in") + cls.product = cls.env["product.product"].create( + { + "name": "Test product", + "type": "product", + } + ) + + cls.sub_location_1 = cls.location_obj.create( + { + "name": "Sub location 1", + "location_id": cls.stock.id, + "usage": "internal", + } + ) + cls.sub_location_2 = cls.location_obj.create( + { + "name": "Sub location 2", + "location_id": cls.stock.id, + "usage": "internal", + } + ) + + cls.rule = cls.rule_obj.create( + { + "product_id": cls.product.id, + "location_in_id": cls.stock.id, + "location_out_id": cls.sub_location_1.id, + } + ) + + def _create_picking(self): + self.picking = self.env["stock.picking"].create( + { + "location_id": self.suppliers.id, + "location_dest_id": self.stock.id, + "picking_type_id": self.type_in.id, + "move_ids": [ + Command.create( + { + "location_id": self.suppliers.id, + "location_dest_id": self.stock.id, + "name": self.product.name, + "product_id": self.product.id, + "product_uom": self.product.uom_id.id, + "product_uom_qty": 10.0, + } + ) + ], + } + ) + return self.picking + + def test_recompute_putaway(self): + """ + Create a single picking from Suppliers -> Stock + The created operation point to the Sub location 1 + Change the rule to point to Sub location 2 + Launch the acdtion to recompute putaways + The operation point to the Sub location 2 + """ + self._create_picking() + self.picking.action_confirm() + + self.assertTrue(self.picking.move_line_ids) + self.assertEqual( + self.sub_location_1, self.picking.move_line_ids.location_dest_id + ) + + # Change the rule destination + self.rule.location_out_id = self.sub_location_2 + + self.picking.action_recompute_putaways() + + self.assertEqual( + self.sub_location_2, self.picking.move_line_ids.location_dest_id + ) + + def test_recompute_putaway_line(self): + """ + Create a single picking from Suppliers -> Stock + The created operation point to the Sub location 1 + Change the rule to point to Sub location 2 + Launch the action to recompute putaways on line level + The operation point to the Sub location 2 + """ + self._create_picking() + self.picking.action_confirm() + + self.assertTrue(self.picking.move_line_ids) + self.assertEqual( + self.sub_location_1, self.picking.move_line_ids.location_dest_id + ) + + # Change the rule destination + self.rule.location_out_id = self.sub_location_2 + + self.picking.move_line_ids.action_recompute_putaways() + + self.assertEqual( + self.sub_location_2, self.picking.move_line_ids.location_dest_id + ) + + def test_recompute_putaway_qty_done(self): + """ + Create a single picking from Suppliers -> Stock + The created operation point to the Sub location 1 + Fill in a quantity to qty_done + Change the rule to point to Sub location 2 + Launch the acdtion to recompute putaways + The operation point still to the Sub location 1 + """ + self._create_picking() + self.picking.action_confirm() + + self.assertTrue(self.picking.move_line_ids) + self.assertEqual( + self.sub_location_1, self.picking.move_line_ids.location_dest_id + ) + + self.picking.move_line_ids.qty_done = 10.0 + # Change the rule destination + self.rule.location_out_id = self.sub_location_2 + + self.picking.action_recompute_putaways() + + # destination location should remain the same + self.assertEqual( + self.sub_location_1, self.picking.move_line_ids.location_dest_id + ) + + def test_recompute_putaway_printed(self): + """ + Create a single picking from Suppliers -> Stock + The created operation point to the Sub location 1 + Set the picking as printed + Change the rule to point to Sub location 2 + Launch the acdtion to recompute putaways + The operation point still to the Sub location 1 + """ + self._create_picking() + self.picking.action_confirm() + + self.assertTrue(self.picking.move_line_ids) + self.assertEqual( + self.sub_location_1, self.picking.move_line_ids.location_dest_id + ) + + self.picking.printed = True + # Change the rule destination + self.rule.location_out_id = self.sub_location_2 + + self.picking.action_recompute_putaways() + + # destination location should remain the same + self.assertEqual( + self.sub_location_1, self.picking.move_line_ids.location_dest_id + ) + + def test_can_recompute(self): + """ + Create a two pickings from Suppliers -> Stock + The visibility of the Recompute button is enabled for both + Set the picking 1 as printed + The visibility of the Recompute button is enabled for picking 2 only + """ + picking1 = self._create_picking() + self.picking.action_confirm() + + self.assertTrue(self.picking.can_recompute_putaways) + + picking2 = self._create_picking() + self.picking.action_confirm() + pickings = picking1 | picking2 + self.assertEqual([True, True], pickings.mapped("can_recompute_putaways")) + + picking1.printed = True + self.assertEqual([False, True], pickings.mapped("can_recompute_putaways")) + + def test_line_can_recompute(self): + """ + Create a two pickings from Suppliers -> Stock + The visibility of the Recompute button is enabled for both + Set the picking 1 as printed + The visibility of the Recompute button is enabled for picking 2 only + """ + picking1 = self._create_picking() + self.picking.action_confirm() + + self.assertTrue(self.picking.move_line_ids.can_recompute_putaways) + + picking2 = self._create_picking() + self.picking.action_confirm() + move_lines = (picking1 | picking2).move_line_ids + self.assertEqual([True, True], move_lines.mapped("can_recompute_putaways")) + + picking1.printed = True + self.assertEqual([False, True], move_lines.mapped("can_recompute_putaways")) + + picking1.printed = False + picking2.move_line_ids.qty_done = 10.0 + self.assertEqual([True, False], move_lines.mapped("can_recompute_putaways")) diff --git a/stock_picking_putaway_recompute/views/stock_move_line.xml b/stock_picking_putaway_recompute/views/stock_move_line.xml new file mode 100644 index 000000000000..ec3b599d349e --- /dev/null +++ b/stock_picking_putaway_recompute/views/stock_move_line.xml @@ -0,0 +1,29 @@ + + + + + stock.move.line.operations.tree (in stock_picking_putaway_recompute) + stock.move.line + + + + + + + + + + + diff --git a/stock_picking_putaway_recompute/views/stock_picking_type.xml b/stock_picking_putaway_recompute/views/stock_picking_type.xml new file mode 100644 index 000000000000..bbcc1b98b681 --- /dev/null +++ b/stock_picking_putaway_recompute/views/stock_picking_type.xml @@ -0,0 +1,19 @@ + + + + + + stock.picking.type.form (in stock_picking_putaway_recompute) + stock.picking.type + + + + + + + + + From 43043bcb86bfdb7471ba4048bfd08516b6afc0ed Mon Sep 17 00:00:00 2001 From: Denis Roussel Date: Thu, 10 Oct 2024 10:25:03 +0200 Subject: [PATCH 2/3] [IMP] stock_picking_putaway_recompute: Don't authorize recompute with packages As soon as there is a result package for the operation, the destination location recomputation is not authorized as all operations contained in a package should go to the same destination. --- stock_picking_putaway_recompute/README.rst | 3 +- .../models/stock_move_line.py | 1 + .../readme/USAGE.md | 3 +- .../static/description/index.html | 3 +- .../tests/test_recompute_putaway.py | 97 +++++++++++++++++-- 5 files changed, 95 insertions(+), 12 deletions(-) diff --git a/stock_picking_putaway_recompute/README.rst b/stock_picking_putaway_recompute/README.rst index a78e03cbc77a..4db7acea2e11 100644 --- a/stock_picking_putaway_recompute/README.rst +++ b/stock_picking_putaway_recompute/README.rst @@ -64,7 +64,8 @@ Usage - If a putaway rule has been changed after product reservation, click on the button 'Recompute putaways'. This will recompute the destination locations on all detailed operations that have no done - quantity yet. + quantity yet and no result package (as all operations for the same + package should go to the same destination). - Moreover, the action is available on picking level and on detailed operation one too. diff --git a/stock_picking_putaway_recompute/models/stock_move_line.py b/stock_picking_putaway_recompute/models/stock_move_line.py index 22b74ef7bf65..6237802fcafc 100644 --- a/stock_picking_putaway_recompute/models/stock_move_line.py +++ b/stock_picking_putaway_recompute/models/stock_move_line.py @@ -34,6 +34,7 @@ def _filtered_for_putaway_recompute(self) -> Self: return self.filtered( lambda line: line.picking_type_id.allow_to_recompute_putaways and not line.picking_id.printed + and not line.result_package_id and not line.qty_done ) diff --git a/stock_picking_putaway_recompute/readme/USAGE.md b/stock_picking_putaway_recompute/readme/USAGE.md index 2a92f2d3174e..a77212c7c583 100644 --- a/stock_picking_putaway_recompute/readme/USAGE.md +++ b/stock_picking_putaway_recompute/readme/USAGE.md @@ -3,5 +3,6 @@ enabled. - If a putaway rule has been changed after product reservation, click on the button 'Recompute putaways'. This will recompute the destination locations - on all detailed operations that have no done quantity yet. + on all detailed operations that have no done quantity yet and no result package + (as all operations for the same package should go to the same destination). - Moreover, the action is available on picking level and on detailed operation one too. diff --git a/stock_picking_putaway_recompute/static/description/index.html b/stock_picking_putaway_recompute/static/description/index.html index b9e9d767ff93..09ddb887e0b8 100644 --- a/stock_picking_putaway_recompute/static/description/index.html +++ b/stock_picking_putaway_recompute/static/description/index.html @@ -413,7 +413,8 @@

Usage

  • If a putaway rule has been changed after product reservation, click on the button ‘Recompute putaways’. This will recompute the destination locations on all detailed operations that have no done -quantity yet.
    • +quantity yet and no result package (as all operations for the same +package should go to the same destination).
  • Moreover, the action is available on picking level and on detailed operation one too.
    • diff --git a/stock_picking_putaway_recompute/tests/test_recompute_putaway.py b/stock_picking_putaway_recompute/tests/test_recompute_putaway.py index 095a2c38c124..ea1aade0e645 100644 --- a/stock_picking_putaway_recompute/tests/test_recompute_putaway.py +++ b/stock_picking_putaway_recompute/tests/test_recompute_putaway.py @@ -1,6 +1,6 @@ # Copyright 2024 ACSONE SA/NV # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -from odoo.fields import Command +from odoo.fields import Command, first from odoo.addons.base.tests.common import BaseCommon @@ -14,12 +14,19 @@ def setUpClass(cls): cls.suppliers = cls.env.ref("stock.stock_location_suppliers") cls.stock = cls.env.ref("stock.stock_location_stock") cls.type_in = cls.env.ref("stock.picking_type_in") + cls.type_in.allow_to_recompute_putaways = True cls.product = cls.env["product.product"].create( { "name": "Test product", "type": "product", } ) + cls.product_2 = cls.env["product.product"].create( + { + "name": "Test product 2", + "type": "product", + } + ) cls.sub_location_1 = cls.location_obj.create( { @@ -43,6 +50,16 @@ def setUpClass(cls): "location_out_id": cls.sub_location_1.id, } ) + # Create the same rule for product 2 + cls.rule_2 = cls.rule_obj.create( + { + "product_id": cls.product_2.id, + "location_in_id": cls.stock.id, + "location_out_id": cls.sub_location_1.id, + } + ) + + cls.package = cls.env["stock.quant.package"].create({}) def _create_picking(self): self.picking = self.env["stock.picking"].create( @@ -60,7 +77,17 @@ def _create_picking(self): "product_uom": self.product.uom_id.id, "product_uom_qty": 10.0, } - ) + ), + Command.create( + { + "location_id": self.suppliers.id, + "location_dest_id": self.stock.id, + "name": self.product.name, + "product_id": self.product_2.id, + "product_uom": self.product.uom_id.id, + "product_uom_qty": 10.0, + } + ), ], } ) @@ -88,7 +115,7 @@ def test_recompute_putaway(self): self.picking.action_recompute_putaways() self.assertEqual( - self.sub_location_2, self.picking.move_line_ids.location_dest_id + self.sub_location_2, first(self.picking.move_line_ids).location_dest_id ) def test_recompute_putaway_line(self): @@ -113,7 +140,7 @@ def test_recompute_putaway_line(self): self.picking.move_line_ids.action_recompute_putaways() self.assertEqual( - self.sub_location_2, self.picking.move_line_ids.location_dest_id + self.sub_location_2, first(self.picking.move_line_ids).location_dest_id ) def test_recompute_putaway_qty_done(self): @@ -202,16 +229,68 @@ def test_line_can_recompute(self): picking1 = self._create_picking() self.picking.action_confirm() - self.assertTrue(self.picking.move_line_ids.can_recompute_putaways) + self.assertEqual( + [True, True], self.picking.move_line_ids.mapped("can_recompute_putaways") + ) picking2 = self._create_picking() self.picking.action_confirm() - move_lines = (picking1 | picking2).move_line_ids - self.assertEqual([True, True], move_lines.mapped("can_recompute_putaways")) + move_lines_picking1 = picking1.move_line_ids + self.assertEqual( + [True, True], move_lines_picking1.mapped("can_recompute_putaways") + ) + + move_lines_picking2 = picking2.move_line_ids + self.assertEqual( + [True, True], move_lines_picking2.mapped("can_recompute_putaways") + ) picking1.printed = True - self.assertEqual([False, True], move_lines.mapped("can_recompute_putaways")) + move_lines_picking1 = picking1.move_line_ids + self.assertEqual( + [False, False], move_lines_picking1.mapped("can_recompute_putaways") + ) + move_lines_picking2 = picking2.move_line_ids + self.assertEqual( + [True, True], move_lines_picking2.mapped("can_recompute_putaways") + ) picking1.printed = False picking2.move_line_ids.qty_done = 10.0 - self.assertEqual([True, False], move_lines.mapped("can_recompute_putaways")) + move_lines_picking1 = picking1.move_line_ids + self.assertEqual( + [True, True], move_lines_picking1.mapped("can_recompute_putaways") + ) + move_lines_picking2 = picking2.move_line_ids + self.assertEqual( + [False, False], move_lines_picking2.mapped("can_recompute_putaways") + ) + + def test_recompute_putaway_packaging(self): + """ + Create a single picking from Suppliers -> Stock + The created operation point to the Sub location 1 + Simulate a package presence on operations + Change the rule to point to Sub location 2 + Launch the action to recompute putaways + The operation still points to the Sub location 1 + """ + self._create_picking() + self.picking.action_confirm() + + self.assertTrue(self.picking.move_line_ids) + self.assertEqual( + self.sub_location_1, self.picking.move_line_ids.location_dest_id + ) + + # Simulate the package is already set + self.picking.move_line_ids.result_package_id = self.package + + # Change the rule destination + self.rule.location_out_id = self.sub_location_2 + + self.picking.action_recompute_putaways() + + self.assertEqual( + self.sub_location_1, self.picking.move_line_ids.location_dest_id + ) From ff1b4bfdface0594bff573eccac9a423ed40ee08 Mon Sep 17 00:00:00 2001 From: Denis Roussel Date: Thu, 10 Oct 2024 10:28:21 +0200 Subject: [PATCH 3/3] [IMP] stock_picking_putaway_recompute: Add a test with option deactivation --- .../tests/test_recompute_putaway.py | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/stock_picking_putaway_recompute/tests/test_recompute_putaway.py b/stock_picking_putaway_recompute/tests/test_recompute_putaway.py index ea1aade0e645..87a8b72ec476 100644 --- a/stock_picking_putaway_recompute/tests/test_recompute_putaway.py +++ b/stock_picking_putaway_recompute/tests/test_recompute_putaway.py @@ -294,3 +294,32 @@ def test_recompute_putaway_packaging(self): self.assertEqual( self.sub_location_1, self.picking.move_line_ids.location_dest_id ) + + def test_no_recompute_putaway(self): + """ + Create a single picking from Suppliers -> Stock + The created operation point to the Sub location 1 + Deactivate the option on picking type level + Change the rule to point to Sub location 2 + Launch the action to recompute putaways + The operation still points to the Sub location 1 + """ + self._create_picking() + self.picking.action_confirm() + + self.assertTrue(self.picking.move_line_ids) + self.assertEqual( + self.sub_location_1, self.picking.move_line_ids.location_dest_id + ) + + # Simulate the package is already set + self.type_in.allow_to_recompute_putaways = False + + # Change the rule destination + self.rule.location_out_id = self.sub_location_2 + + self.picking.action_recompute_putaways() + + self.assertEqual( + self.sub_location_1, self.picking.move_line_ids.location_dest_id + )