From c40d554574b6ec5d73e4bf5fb9d6c739acefdb86 Mon Sep 17 00:00:00 2001
From: jfrer <jasper.frerichs@sub.uni-goettingen.de>
Date: Fri, 19 Jul 2024 14:39:00 +0200
Subject: [PATCH 1/6] fix: make showTextColors Prop optional

---
 src/components/workflows/TrendLegend.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/workflows/TrendLegend.vue b/src/components/workflows/TrendLegend.vue
index 4cf71bb..80ddcce 100644
--- a/src/components/workflows/TrendLegend.vue
+++ b/src/components/workflows/TrendLegend.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
 const props = withDefaults(defineProps<{
-  showTextColors: boolean
+  showTextColors?: boolean
 }>(), {
   showTextColors: true
 })

From 3eb06a7ac331fe018587364170f7d8b81f65a946 Mon Sep 17 00:00:00 2001
From: jfrer <jasper.frerichs@sub.uni-goettingen.de>
Date: Fri, 19 Jul 2024 14:47:10 +0200
Subject: [PATCH 2/6] wrap charts and overlaypanels in div to allow props to be
 inherited by a single root element

---
 .../workflows/timeline/MetricAverageChart.vue | 66 ++++++++++---------
 .../workflows/timeline/MetricChart.vue        | 66 ++++++++++---------
 2 files changed, 68 insertions(+), 64 deletions(-)

diff --git a/src/components/workflows/timeline/MetricAverageChart.vue b/src/components/workflows/timeline/MetricAverageChart.vue
index 54e6a93..c92ff14 100644
--- a/src/components/workflows/timeline/MetricAverageChart.vue
+++ b/src/components/workflows/timeline/MetricAverageChart.vue
@@ -65,39 +65,41 @@ function tooltipContent(d: TimelineChartDataPoint) {
 </script>
 
 <template>
-  <div @click="op?.toggle($event)" class="cursor-pointer flex">
-    <BaseTimelineChart
-      :data="data"
-      :max-y="maxY"
-      :start-date="startDate"
-      :end-date="endDate"
-      :tooltip-content="tooltipContent"
-      :width="400"
-      :higher-is-positive="isHigherPositive(metric)"
-    />
+  <div>
+    <div @click="op?.toggle($event)" class="cursor-pointer flex">
+      <BaseTimelineChart
+        :data="data"
+        :max-y="maxY"
+        :start-date="startDate"
+        :end-date="endDate"
+        :tooltip-content="tooltipContent"
+        :width="400"
+        :higher-is-positive="isHigherPositive(metric)"
+      />
+    </div>
+    <OverlayPanel
+      ref="op"
+      :pt="{
+        root: {
+          class: 'z-[1111] bg-white border rounded-md shadow-md p-5'
+        }
+      }"
+    >
+      <BaseTimelineDetailedChart
+        :data="data"
+        :max-y="maxY"
+        :y-axis-title="`${t(metric)} (${t(getUnitOfMetric(metric))})`"
+        :workflow="workflowName"
+        :label="gtName"
+        :start-date="startDate"
+        :end-date="endDate"
+        :tooltip-content="tooltipContent"
+        :height="400"
+        :width="660"
+        :higher-is-positive="isHigherPositive(metric)"
+      />
+    </OverlayPanel>
   </div>
-  <OverlayPanel
-    ref="op"
-    :pt="{
-      root: {
-        class: 'z-[1111] bg-white border rounded-md shadow-md p-5'
-      }
-    }"
-  >
-    <BaseTimelineDetailedChart
-      :data="data"
-      :max-y="maxY"
-      :y-axis-title="`${t(metric)} (${t(getUnitOfMetric(metric))})`"
-      :workflow="workflowName"
-      :label="gtName"
-      :start-date="startDate"
-      :end-date="endDate"
-      :tooltip-content="tooltipContent"
-      :height="400"
-      :width="660"
-      :higher-is-positive="isHigherPositive(metric)"
-    />
-  </OverlayPanel>
 </template>
 
 <style scoped lang="scss">
diff --git a/src/components/workflows/timeline/MetricChart.vue b/src/components/workflows/timeline/MetricChart.vue
index 39d039e..24ecd97 100644
--- a/src/components/workflows/timeline/MetricChart.vue
+++ b/src/components/workflows/timeline/MetricChart.vue
@@ -52,39 +52,41 @@ function tooltipContent(d: TimelineChartDataPoint) {
 </script>
 
 <template>
-  <div @click="op?.toggle($event)" class="cursor-pointer flex justify-end">
-    <BaseTimelineChart
-      :data="data"
-      :max-y="maxY"
-      :start-date="startDate"
-      :end-date="endDate"
-      :tooltip-content="tooltipContent"
-      :width="400"
-      :higher-is-positive="isHigherPositive(metric)"
-    />
+  <div>
+    <div @click="op?.toggle($event)" class="cursor-pointer flex justify-end">
+      <BaseTimelineChart
+        :data="data"
+        :max-y="maxY"
+        :start-date="startDate"
+        :end-date="endDate"
+        :tooltip-content="tooltipContent"
+        :width="400"
+        :higher-is-positive="isHigherPositive(metric)"
+      />
+    </div>
+    <OverlayPanel
+      ref="op"
+      :pt="{
+        root: {
+          class: 'z-[1111] bg-white border rounded-md shadow-md p-5'
+        }
+      }"
+    >
+      <BaseTimelineDetailedChart
+        :data="data"
+        :max-y="maxY"
+        :y-axis-title="`${t(metric)} (${t(getUnitOfMetric(metric))})`"
+        :workflow="workflowName"
+        :label="gtName"
+        :start-date="startDate"
+        :end-date="endDate"
+        :tooltip-content="tooltipContent"
+        :height="400"
+        :width="660"
+        :higher-is-positive="isHigherPositive(metric)"
+      />
+    </OverlayPanel>
   </div>
-  <OverlayPanel
-    ref="op"
-    :pt="{
-      root: {
-        class: 'z-[1111] bg-white border rounded-md shadow-md p-5'
-      }
-    }"
-  >
-    <BaseTimelineDetailedChart
-      :data="data"
-      :max-y="maxY"
-      :y-axis-title="`${t(metric)} (${t(getUnitOfMetric(metric))})`"
-      :workflow="workflowName"
-      :label="gtName"
-      :start-date="startDate"
-      :end-date="endDate"
-      :tooltip-content="tooltipContent"
-      :height="400"
-      :width="660"
-      :higher-is-positive="isHigherPositive(metric)"
-    />
-  </OverlayPanel>
 </template>
 
 <style scoped lang="scss">

From 8500f4ecf878675d92c95166044b7d999a9bb07a Mon Sep 17 00:00:00 2001
From: jfrer <jasper.frerichs@sub.uni-goettingen.de>
Date: Fri, 19 Jul 2024 14:51:36 +0200
Subject: [PATCH 3/6] fix: remove translations lookup from processor labels as
 they currently dont need translation

---
 src/components/workflows/timeline/TimelineFilters.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/workflows/timeline/TimelineFilters.vue b/src/components/workflows/timeline/TimelineFilters.vue
index de050d3..94bf00a 100644
--- a/src/components/workflows/timeline/TimelineFilters.vue
+++ b/src/components/workflows/timeline/TimelineFilters.vue
@@ -111,7 +111,7 @@ watch(() => filtersStore.gt, () => {
 })
 
 onMounted(() => {
-  workflowStepOptions.value = deduplicateStepIds(workflowsStore.workflows).map(id => ({ value: id, label: t(id) }))
+  workflowStepOptions.value = deduplicateStepIds(workflowsStore.workflows).map(id => ({ value: id, label: id }))
   
   selectedDateRange.value = dateRangeOptions.value
   selectedWorkflows.value = workflowOptions.value

From 7b93d6f50e6c9fde5fd36a2a28c55c8beec17dd8 Mon Sep 17 00:00:00 2001
From: jfrer <jasper.frerichs@sub.uni-goettingen.de>
Date: Fri, 19 Jul 2024 15:15:33 +0200
Subject: [PATCH 4/6] fix: remove old i-icon, improve tooltip structure

---
 src/components/workflows/WorkflowsTable.vue | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/components/workflows/WorkflowsTable.vue b/src/components/workflows/WorkflowsTable.vue
index f42c6f2..057ee9e 100644
--- a/src/components/workflows/WorkflowsTable.vue
+++ b/src/components/workflows/WorkflowsTable.vue
@@ -8,6 +8,7 @@ import workflowsStore from "@/store/workflows-store"
 import api from "@/helpers/api"
 import filtersStore from "@/store/filters-store"
 import TrendLegend from "@/components/workflows/TrendLegend.vue"
+import { Icon } from '@iconify/vue'
 
 const { t } = useI18n()
 
@@ -134,11 +135,13 @@ const groupByDocuments = () => {
         <th v-for="(evalKey, i) in evals" :key="i" class="p-2 border">
           <span class="def-label flex items-center justify-center cursor-pointer">
             {{ evalDefinitions[evalKey] ? evalDefinitions[evalKey].label : evalKey }}
-            <i-icon name="ink-info"/>
             <div class="def-tooltip">
-              <div class="flex p-2 bg-white border rounded">
-                {{ evalDefinitions[evalKey] ? evalDefinitions[evalKey].short_descr : $t('no_description') }}.
-                <a v-if="evalDefinitions[evalKey]" :href="evalDefinitions[evalKey].url">{{ $t('details') }}</a>
+              <div class="flex p-2 bg-white border rounded space-x-2 items-start">
+                <span>{{ evalDefinitions[evalKey] ? evalDefinitions[evalKey].short_descr : $t('no_description') }}.</span>
+                <a v-if="evalDefinitions[evalKey]" :href="evalDefinitions[evalKey].url" class="flex items-center text-xs">
+                  <Icon icon="material-symbols:info-outline" class="mr-1"></Icon>
+                  <span>{{ $t('details') }}</span>
+                </a>
               </div>
             </div>
           </span>

From f7028b8e7f3d513d82bb581a54f0558109e9a5aa Mon Sep 17 00:00:00 2001
From: jfrer <jasper.frerichs@sub.uni-goettingen.de>
Date: Fri, 19 Jul 2024 15:18:10 +0200
Subject: [PATCH 5/6] fix: add i18n details key to en

---
 src/locales/en.json | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/locales/en.json b/src/locales/en.json
index 2fc3f36..d17cf04 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -1,4 +1,5 @@
 {
+  "details": "Details",
   "projects": "Projects",
   "processors": "Processors",
   "workflows": "Workflows",

From 6693bcc56d94ab81606f0842d81643297e976f87 Mon Sep 17 00:00:00 2001
From: jfrer <jasper.frerichs@sub.uni-goettingen.de>
Date: Fri, 19 Jul 2024 15:31:09 +0200
Subject: [PATCH 6/6] fix: typo in script-type key in i18n de

---
 src/locales/de.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/locales/de.json b/src/locales/de.json
index db55ba1..4b26057 100644
--- a/src/locales/de.json
+++ b/src/locales/de.json
@@ -75,7 +75,7 @@
   "url": "URL",
   "language": "Sprache | Sprachen",
   "script": "Skript | Skripte",
-  "scripttype": "Skript-Typ",
+  "script-type": "Skript-Typ",
   "license": "Lizenz | Lizenzen",
   "volume": "Umfang",
   "labelling": "Kennzeichnung",