Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest RESTier and OData libraries #223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikepizzo
Copy link
Member

Fixes #218
Also fixes OData/odataorg.github.io#369

Updates to latest RESTier/OData and makes sure collection values in sample data are initialized.


public Person()
{
Emails = new List<string>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to create/allocate empty list for those collection properties looks 'annoying'.

I know OData spec requires collection should not be null. But, Why? can we change this 'Rule'?

From C# perspective, a collection value call be:

  1. null
  2. empty
  3. items

@robertmclaws
Copy link

You might want to wait to accept this until Restier 1.1.1 comes out at the end of the week. There is a threading issue on batched changes that someone reported, and we changed the internals to use ConcurrentDictionary. There is an RC version out for this now, and I'm planning on shipping an RTM by Friday.

@robertmclaws
Copy link

Restier 1.1.1 has been released. If you update the references here you should be good to go. Thanks!

Copy link
Member

@marabooy marabooy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM should we update to use the new restier version released today?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants