Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [measurements panel] rendering delete button when text is too wide for parent div #1526

Conversation

Geenzo
Copy link
Contributor

@Geenzo Geenzo commented Mar 15, 2020

Changes

Fixes issue #1377 delete button was disappearing due to overflowing into a row new when spanish is the selected language

Screenshots

English

image

Spanish

image

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6ed1e47). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1526   +/-   ##
=========================================
  Coverage          ?   11.68%           
=========================================
  Files             ?      273           
  Lines             ?     7003           
  Branches          ?     1309           
=========================================
  Hits              ?      818           
  Misses            ?     5017           
  Partials          ?     1168
Flag Coverage Δ
#core 16.69% <ø> (?)
#viewer 0.37% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed1e47...f8d2485. Read the comment docs.

@dannyrb
Copy link
Member

dannyrb commented Mar 17, 2020

Not beautiful, but it's better than the button not showing.
Thanks for the PR!

@dannyrb dannyrb merged commit b269415 into OHIF:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants