Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When OHIF is configured with OIDC after auth it redirects to callbackurl again, another refresh works #2850

Closed
smithago opened this issue Jul 27, 2022 · 10 comments
Assignees
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)

Comments

@smithago
Copy link

Bug Report

Describe the Bug

OHIF viewer is configured with OIDC properties to support authenticated access to backend service.
After the auth redirections and confirmation, ohif redirects to callbackurl.

Refreshing the base url works.

What steps can we follow to reproduce the bug?

We have a github repo on how to configure ohif viewer to Azure DICOM service and deploy ohif viewer as a static website in storage account.
https://github.com/microsoft/dicom-ohif
It has step by step instructions on how to set it up.

If you follow this and authenticate, you will run into the final stage of redirection to callbackurl.

It is also mentioned as a github issue from one of our customers
microsoft/dicom-ohif#7

⚠️ Reports we cannot reproduce are at risk of being marked stale and
closed. The more information you can provide, the more likely we are to look
into and address your issue.

@sedghi
Copy link
Member

sedghi commented Jul 27, 2022

Hey @smithago , thanks for the report. Can you try v3-stable and see if the problem still exists?

@smithago
Copy link
Author

smithago commented Jul 28, 2022

Will do @sedghi . How do I access v3-stable? I have only seen you release the entire source code and containers. I assume sync to that branch and generate the files and try.

@smithago
Copy link
Author

I just tried, looks like lot of steps have changed in that branch. Here is what I was doing to generate index.html and minified and webpacked index.umd.js.*

cd platform/viewer
Yarn install
yarn run build:package

Looks like the build:package is missing and the webpack.commonjs.js

@sedghi
Copy link
Member

sedghi commented Jul 28, 2022

you don't need to cd into viewer, run the yarn build at the root of the monorepo, the build files with (index.html) will become available in the platform/viewer/dist

@smithago
Copy link
Author

It still has too many files. Before when I did the yarn run build:package, it just gave me the minimum basic, like below

image

Now if I upload all the content from platform/viewer/dist Is is blank when I browse index.html.

@sedghi
Copy link
Member

sedghi commented Jul 29, 2022

Where do you upload the content? This doc page might be helpful https://v3-docs.ohif.org/deployment/build-for-production/

@smithago
Copy link
Author

smithago commented Sep 2, 2022

I upload the content to Azure Blob container with static website enabled. The build has changed in v3, I am not able to produce the same minified and merged content. Can someone help me?

@sedghi
Copy link
Member

sedghi commented Sep 9, 2022

The built get separated into chunks, but still if you get index.html and main javascript bundle generated it knows each chunk path and load them as necessary. Can you send me an email at [email protected] , we can setup a meeting to fix this

@sedghi
Copy link
Member

sedghi commented Oct 13, 2023

@jbocce ditto

@sedghi sedghi self-assigned this Oct 18, 2023
@sedghi sedghi added the Awaiting Reproduction Can we reproduce the reported bug? label Oct 18, 2023
@sedghi sedghi added fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) and removed Awaiting Reproduction Can we reproduce the reported bug? labels Jan 9, 2024
@sedghi
Copy link
Member

sedghi commented May 1, 2024

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.

@sedghi sedghi closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)
Projects
None yet
Development

No branches or pull requests

2 participants