-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Study with Photometric Interpretation YBR_FULL_422 are "green" #2887
Comments
I'm investigating this early next week. |
is this still happening in the latest master branch? |
Hi @sedghi I will check next week. |
We had couple of fixes, so please try |
same issue v3.8.0beta-27 |
Could you kindly provide the data if it has been anonymized and you can confirm that there is no patient health information present in any of the headers or embedded within the pixel data? |
Check out the latest master branch, it is most likely fixed |
I'm running 3.8.0-beta.54 and still seeing the same issue here. Do you still need some test data ? I might be able to provide some if it's still needed. |
It's not just about the data, but also about what servers do (arbitrarily). It would make sense to send both the data and server information. |
@BITC01 Cloning the latest version should solve the problem. Adding this : dataSources: [ |
You don't need this even anymore, it is default |
but try |
I tried that but it didn't work unfortunately, We are not using OrthanC as our server so it's something else. Content-Type: "image/jpeg"; transfer-syntax=1.2.840.10008.1.2.4.57 Thanks for looking into this. P.S. I've also looked at 0028,0004(PHOTOMETRIC) in metadata we are sending YBR_FULL. |
As i said it is about servers, they sometimes tell (in metadata) that it is YBR_FULL but in reality it is something else. So it is a bug in your server, we are trying to catch those anomalies here, maybe stay tuned and that will fix it, but in reality it is the server issue cornerstonejs/cornerstone3D#829 |
I have written a bit of code to replace the metadata with whatever it "should" be. Can you tell me how I can figure out what it should be. I've replaced the metadata with "RGB" , "YBR_FULL_422" and neither of those values make a difference. If I can see it in the BINARY data somewhere maybe that would lead me to the right place ? |
The server should respond with whatever the client is asking, if it is asking for * it should return as it is, and if it converts the color spaces the metadata should be in sync you can read more here https://discourse.orthanc-server.org/t/orthanc-convert-ybr-to-rgb-but-does-not-change-metadata/3533?u=alireza |
I read that thread before posting here. It is what lead me to believe that the issue is the colorspace. However unlike in orthanc , our server simply sends back the pixeldata AS IS. The server does not decompress it , thus the Metadata PHOTOMETRIC value and the actual colorspace for the pixel data should be in sync naturally. However I'm still seeing the green overlay. |
YBR and RGB can't be easily distinguished by the pixel data. I've shared a link to a PR in Cornerstone3D. Once it's merged, it might solve your problem. In the meantime, you can try checking out that branch and locally linking it to OHIF for testing purposes. |
just a small added bit of info JIC it makes a difference . We are using Dgate for the dicom compression. |
@sedghi |
@sedghi
I'm not a big react person so I'm at a bit of a loss as to where to go from here. If you might have a pointer in the correct direction that would be great. |
You need to upgrade vtk.js on OHIF, we have PRs soon, but since you are linking you should add that |
@sedghi |
closing in favor of #4082 |
Hello to everyone,
when I try to visualize a study with Photometric Interpretation YBR_FULL_422 the images are "green". Seems like there is trouble with the color channels.
If I open the same study with another viewer (weasis or osirix) the images are correctly shown.
I have this problem with OHIF Viewer v2 and v3-stable.
Below is a snippet of the viewer configuration
imageRendering: 'wadors'
thumbnailRendering: 'wadors'
If I replace wadors with wadouri the images are correctly shown.
Can you help me?
The text was updated successfully, but these errors were encountered: