_isValidMeasurement mistake

[HNTQ]

Hello,

Bug Report

Describe the Bug

There is an issue to _isValidMeasurement function.
It will never return false because return is inside forEach loop.

Viewers/platform/core/src/services/MeasurementService/MeasurementService.js

Lines 651 to 660 in 686fe7d

	_isValidMeasurement(measurementData) {
	Object.keys(measurementData).forEach(key => {
	if (!MEASUREMENT_SCHEMA_KEYS.includes(key)) {
	log.warn(`Invalid measurement key: ${key}`);
	return false;
	}
	});
	return true;
	}

This function is used inside addRawMeasurement function

Viewers/platform/core/src/services/MeasurementService/MeasurementService.js

Lines 363 to 368 in 686fe7d

	if (!this._isValidMeasurement(measurement)) {
	log.warn(
	`Attempting to add or update a invalid measurement provided by '${sourceInfo}'. Exiting early.`
	);
	return;
	}

The warn is never prompt in console and function continue and add measurement:

One possible solution:

       _isValidMeasurement(measurementData) {
        const _isValidKey = key => MEASUREMENT_SCHEMA_KEYS.includes(key)
    
        return Object.keys(measurementData).every(key => {
          if (!_isValidKey(key)) {
            log.warn(`Invalid measurement key: ${key}`);
            return false;
          }
          return true;
        });
      }