Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] When creating a new segmentation in [Segmentation Mode] there is no way to tell which series is being segmented #3790

Closed
BrandonDatUHN opened this issue Nov 15, 2023 · 6 comments
Assignees
Labels
Design Added fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)

Comments

@BrandonDatUHN
Copy link

What feature or change would you like to see made?

When a user opens any study (with more than one series) in [Segmentation Mode] and adds a new segmentation, that segmentation will be based upon one series. Many series may share that Frame of Reference and it will display on all of those, however, the segmentation is linked directly to only 1.

It appears whichever panel is selected when the "New Segmentation" is clicked will become the reference image for the segmentation. When saving the DICOM SEG back to PACS and then loading it in basic mode it will pull up that reference image set.

In this example I made the hair on CTAC (Top left), eyes on CTSTD (top right), Nose on AC256 (bottom left) and Mouth on NAC (bottom right)

image

The issue is there is no way to know which segmentation is linked to what series when segmenting in segmentation mode.

Additionally All the Segment 1's seem to be linked by colour. If I change it for one Segmentation it changes for all.

image

Perhaps a better example would be in a 4D CT. A user would want a different segmentation on each breathing phase. Right now the only way I have any idea which is which is by making sure I have the right one selected when I click new segmentation and then relabelling them.

image

Somewhere it should really tell you

  1. Which series is this segmentation linked to and
  2. Selecting a Segment should localize to the segment and highlight the correct panel.

image

Why should we prioritize this feature?

Right now this feature works okay with a couple series and users who think to label their segmentations. But when you get to larger series where a user wants to segment on one as opposed to another it's going to get very confusing if the user doesn't know which series a segmentation is linked to.

@sedghi
Copy link
Member

sedghi commented Nov 22, 2023

I think it makes sense

@jenny-hm-lee
Copy link

jenny-hm-lee commented Nov 29, 2023

Hi all,

I hope to make things easier by summarizing the requirements of this issue. These requirements would applies to both basic and segmentation mode.

On the segmentation panel, for each dicom segmentation

  • For each segment, we should indicate what is the primary series it was originally contoured. We should follow the same display format as annotation.
  • When user clicks on a segment, the viewport of the primary series should be highlighted and navigate to the segment.

Say, Segmentation 1 has Segment 1, and Segmentation 2 has Segment 1. Currently, changing the colour of (Segmentation 1, Segment 1) also changes the colour of (Segmentation 2 Segment 1). This should not happen.

On the viewport,

  • Say segment A is contoured on series A. Then, the segment A should displayed with solid boundary line on series A.
  • On any series B sharing the same FoR as series A, the segment A should be displayed with dotted boundary line of the same colour. This gives a clear meaning that the segment can be visualized on series B because it shares the same physical space; but it was not where it was contoured. This is also what Raystation does.

@james-hanks
Copy link

We will discuss during our design review and provide update design once we have decided how to approach

@fedorov
Copy link
Member

fedorov commented Nov 30, 2023

I think this is related to this issue: #3421

@sedghi
Copy link
Member

sedghi commented Feb 21, 2024

This is the design

CleanShot 2024-02-21 at 13 40 28

@sedghi sedghi added the fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) label Apr 3, 2024
@sedghi
Copy link
Member

sedghi commented May 1, 2024

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.

@sedghi sedghi closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Added fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)
Projects
None yet
Development

No branches or pull requests

7 participants