[Bug] Green screen

[narbek-abd]

Describe the Bug

Hi.
Here is an archive.
e5824449-2d66de43-8459fe70-9ff5359c-97655c13.zip

After this commit 6651008 i see green screen for this study. In local mode it works, but I I use osimis/orthanc:22.11.3 and I downloaded source code before and after this commit and it was ok before this commit, so i don't think it is an issue with Orthanc

Steps to Reproduce

1. use osimis/orthanc:22.11.3
2. download source code before provided commit
3. open the study

The current behavior

green screen

The expected behavior

proper viewer

OS

all

Node version

all

Browser

all

[niirdan]

same issue here , using google.js configuration latest version .
there is an estimated time for a fix ?

[sedghi]

I don't think it is related to that commit honestly. This is a long lasting bug in Orthanc that we tried to communicate to fix, but they fixed and later reverted the fix. https://discourse.orthanc-server.org/t/orthanc-convert-ybr-to-rgb-but-does-not-change-metadata/3533/16

[sedghi]

I posted a comment there https://discourse.orthanc-server.org/t/orthanc-convert-ybr-to-rgb-but-does-not-change-metadata/3533/19?u=alireza

[niirdan]

hey @sedghi thanks for your answer, this is very appreciated ! how does orthanc works inside ohif ? is it a remote server that the ohif sends a request or this is a static node module , because if it is a node module , maybe the temporary solution is to downgrade it to the version with the fix that they released ?

[sedghi]

seems like this will help

https://discourse.orthanc-server.org/t/orthanc-convert-ybr-to-rgb-but-does-not-change-metadata/3533/20?u=alireza

[niirdan]

seems like this will help

https://discourse.orthanc-server.org/t/orthanc-convert-ybr-to-rgb-but-does-not-change-metadata/3533/20?u=alireza
@sedghi
this actually fix the issue !!! many thanks for mentioning!
please consider editing google.js in the next branch with this fix

[sedghi]

Checkout lastest master branch, it should have been fixed with the recent push

[sedghi]

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.