fix(rt): enhanced RT support, utilize SVGs for rendering. #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4074 +/- ##
==========================================
- Coverage 46.23% 44.41% -1.83%
==========================================
Files 78 80 +2
Lines 1276 1333 +57
Branches 312 327 +15
==========================================
+ Hits 590 592 +2
- Misses 548 588 +40
- Partials 138 153 +15 ☔ View full report in Codecov by Sentry. |
1 failed test on run #3886 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| OHIF Study List > Desktop resolution > maintains Accession filter upon return from viewer |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #4074 ↗︎
IbrahimCSAE
changed the title
sedghi
requested changes
May 6, 2024
extensions/cornerstone/src/init.tsx
Outdated
| cornerstoneTools.segmentation.config.setGlobalRepresentationConfig(labelmapRepresentation, { | ||
| fillAlpha: 0.5, | ||
| fillAlphaInactive: 0.2, | ||
| outlineOpacity: 1, | ||
| outlineOpacityInactive: 0.65, | ||
| }); | ||
|
|
||
| cornerstoneTools.segmentation.config.setGlobalRepresentationConfig(contourRepresentation, { |
sedghi
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR changes the rendering process for RT contours, in the past we used to pass the
gemoteryIdsto our render function and create a VTK actor with the contour data.Now, this has changed, we are still passing the
gemotryIds, however, we take thosegeomtryIds, and callcache.getGeomtry(geomtryId)on each one, and use its data to create annotations that represent the contour, which gets stored internally and generate anannotationsUIDsMapThis helps us render the contours using SVG which is much more reliable than VTK.
From a user point of view, nothing is changing in the RT loading process, because you are still creating and caching geometries, we just handle them differently internally to generate SVGs instead of a VTK actor.
You will notice your viewports only have 1 actor after loading an RT, which in the past would become 2 actors (1 for the scan,and 1 for RT).