Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sr): rendering issue by running loadSR before updateSR #4226

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

Joeycho
Copy link
Contributor

@Joeycho Joeycho commented Jun 11, 2024

Fix the following issue.
#4205

loadSR should run at least one time, before updateSR is running.

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit c4f6e5e
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66688d71b8f24f0008d6212c
😎 Deploy Preview https://deploy-preview-4226--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit c4f6e5e
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66688d71756c3f0008dee850
😎 Deploy Preview https://deploy-preview-4226--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sedghi sedghi changed the title fix rendering issue by running loadSR before updateSR fix(sr): rendering issue by running loadSR before updateSR Jun 12, 2024
@sedghi sedghi merged commit 6971287 into OHIF:master Jun 12, 2024
5 checks passed
@Joeycho Joeycho deleted the sr-visible-fix branch June 17, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants