Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HP): Frame View HP #4235

Merged
merged 6 commits into from
Jun 21, 2024
Merged

feat(HP): Frame View HP #4235

merged 6 commits into from
Jun 21, 2024

Conversation

IbrahimCSAE
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE commented Jun 16, 2024

Copy link

netlify bot commented Jun 16, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 0340b56
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6673760b92484c000898be3e
😎 Deploy Preview https://deploy-preview-4235--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 16, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 0340b56
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6673760b7c907f0008c4cdcb
😎 Deploy Preview https://deploy-preview-4235--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jun 16, 2024

Passing run #4103 ↗︎

0 44 2 0 Flakiness 0

Details:

Merge branch 'master' into feat/random
Project: Viewers Commit: 0340b56db7
Status: Passed Duration: 05:27 💡
Started: Jun 20, 2024 12:35 AM Ended: Jun 20, 2024 12:40 AM

Review all test suite changes for PR #4235 ↗︎

@IbrahimCSAE IbrahimCSAE changed the title [WIP] feat(HP): Frame View HP feat(HP): Frame View HP Jun 17, 2024
@IbrahimCSAE
Copy link
Collaborator Author

needs an icon if we want this in the layout selector

@IbrahimCSAE IbrahimCSAE requested a review from sedghi June 17, 2024 07:07
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sedghi sedghi merged commit d5d8214 into master Jun 21, 2024
9 checks passed
@deathknight0718
Copy link

@IbrahimCSAE protocolMatchingRules is undefined. so, When using segmentation mode, the following code generates an error.

  findMatchByStudy(study, options) {
    const matched = [];

    this.protocols.forEach(protocol => {
      // Clone the protocol's protocolMatchingRules array
      // We clone it so that we don't accidentally add the
      // numberOfPriorsReferenced rule to the Protocol itself.
      console.log(protocol);
      let rules = protocol.protocolMatchingRules.slice(); // FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants