fix: Use correct external URL for rendered responses with relative URI #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@igoroctaviano - could you test this against the IDC bulkdata responses? I know you added a change to the path, and I think I have that all correct, but I don't have the remote system to test against. |
Passing run #4087 ↗︎
Details:
Review all test suite changes for PR #4236 ↗︎ |
|||||||||||||||
|
Tested - works right on the deploy preview https://deploy-preview-4236--ohif-dev.netlify.app/viewer/ohif3?StudyInstanceUIDs=2.25.96975534054447904995905761963464388233 |
sedghi
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For relative URI's in the metadata for DICOMweb, the standard says you are supposed to use the path provided. However, when we use the direct URL provided for computing paths, the wrong path is chosen, based on the wrong datasource name. This PR uses the correct relative paths for bulkdata whether that is doing rendered display or otherwise.
Changes & Results
Testing
Open up the deploy preview (or e2e config), and use datasources=ohif3
Query for "Horse" as the patient name
Display the vidoe
The video should display.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment