feat: customization service append and customize functionality should run once #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayfarer3130
changed the title
✅ Deploy Preview for ohif-dev canceled.
|
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wayfarer3130
force-pushed
the
feat/customization-service-append-functionality
branch
from
762ff5c
to
a7b3cb2
Compare
Passing run #4102 ↗︎
Details:
Review all test suite changes for PR #4238 ↗︎ |
|||||||||||||||
…rvice-append-functionality
…rvice-append-functionality
wayfarer3130
changed the title
wayfarer3130
commented
Jun 19, 2024
There was a problem hiding this comment.
Fixing the use of the customization service to be correct.
wayfarer3130
commented
Jun 19, 2024
| @@ -3,7 +3,6 @@ const pkg = require('./package'); | |||
|
|
|||
| module.exports = { | |||
| ...base, | |||
| name: pkg.name, | |||
There was a problem hiding this comment.
name isn't a valid field, was causing spurious warnings during the unit test phase of this change.
wayfarer3130
commented
Jun 19, 2024
| @@ -160,5 +165,149 @@ describe('CustomizationService.ts', () => { | |||
| expect(result.label).toBe(testItem.label); | |||
| expect(result.value).toBe(props.testAttribute); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Add a whole bunch of unit tests to show how the services can be used/how to handle the append etc.
wayfarer3130
commented
Jun 19, 2024
There was a problem hiding this comment.
Adds default customizations, which can be used to provide a basis for other changes, and added working merge and append functionality.
wayfarer3130
commented
Jun 19, 2024
There was a problem hiding this comment.
Adding documentation on how to use the new functionality.
wayfarer3130
commented
Jun 19, 2024
| @@ -51,7 +51,7 @@ | |||
| "react-dnd": "14.0.2", | |||
| "react-dnd-html5-backend": "14.0.0", | |||
| "react-dom": "^18.3.1", | |||
| "react-draggable": "4.4.3", | |||
| "react-draggable": "^4.4.6", | |||
There was a problem hiding this comment.
This fixes a persistent warning about react 18 incompatibilities.
sedghi
approved these changes
Jun 19, 2024
wayfarer3130
added a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment