Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tests run against e2e config for both playwright and older tests #4283

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

wayfarer3130
Copy link
Contributor

Context

Runs tests against the
yarn test:e2e:serve
configuration e2e.js so that all tests run against the same configuration.

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit feea52b
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/668d4493bccefc0009c539a9
😎 Deploy Preview https://deploy-preview-4283--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit feea52b
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/668d449368e066000813ee39

Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

cypress bot commented Jul 9, 2024

Passing run #4165 ↗︎

0 44 2 0 Flakiness 0

Details:

increase timeout for server start, undo default.js
Project: Viewers Commit: feea52bc49
Status: Passed Duration: 05:34 💡
Started: Jul 9, 2024 2:23 PM Ended: Jul 9, 2024 2:28 PM

Review all test suite changes for PR #4283 ↗︎

@wayfarer3130 wayfarer3130 merged commit 31271ae into master Jul 9, 2024
14 checks passed
@wayfarer3130 wayfarer3130 deleted the fix/tests-run-against-e2e branch July 9, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants