feat(SR): text structured report (TEXT, CODE, NUM, PNAME, DATE, TIME and DATETIME) #4287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev canceled.
|
sedghi
reviewed
Jul 12, 2024
sedghi
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Very nice addition!
The unit test is failing because you added something to utils in the core. You need to add that to the unit test as well and export it.
@wayfarer3130, I dislike this test.
Yes, I hate that unit test too. |
sedghi
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Added support for text Structure Reports that can contain TEXT, CODE, NUM, PNAME, DATE, TIME and DATETIME content items, nested containers and separate/continous (0040,a050) ContinuityOfContent. The value types IMAGE, WAVEFORM, COMPOSITE, SCOORD and TCOORD are still not supported. The user shall see "[VALUE_TYPE is not supported]" for each of the unsupported value types.
PS 1: SR Measurement (TID 1500) works as before
PS 2: IMAGE value type support will be added soon and SCOORD/TCOORD later.
Screenshots
Testing
Some SR files can be downloaded from here:
https://www.dropbox.com/scl/fi/mmq2ofh88c9ytn7fmkx7z/Structured-Reports.zip?rlkey=46szt3w974jwlgs0paw617t2l&st=0sglct4o&dl=0