Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SR): SCOORD3D point annotations support for stack viewports #4315

Merged
merged 155 commits into from
Oct 17, 2024

Conversation

igoroctaviano
Copy link
Contributor

@igoroctaviano igoroctaviano commented Jul 26, 2024

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

…ohif/Viewers into feat/scoord3d-point-annotations-support
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments please, great work

@igoroctaviano
Copy link
Contributor Author

@sedghi, could you please review this? If any changes or clean-ups are needed, I'll handle them based on your final feedback.

@igoroctaviano igoroctaviano changed the title feat(SR): SCOORD3D point annotations support for volume and stack viewports feat(SR): SCOORD3D point annotations support for stack viewports Oct 17, 2024
@sedghi sedghi merged commit ac1cad2 into master Oct 17, 2024
11 of 15 checks passed
@fedorov
Copy link
Member

fedorov commented Oct 17, 2024

Really happy to see this effort completed! Thank you @igoroctaviano and @sedghi for bringing it over the finish line! 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDC:priority Items that the Imaging Data Commons wants to help sponsor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants