Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add kheops integration into OHIF v3 again #4345

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

wayfarer3130
Copy link
Contributor

Context

The KHEOPS url= integration got broken due to a change int he API. This PR just adds it back in.

Changes & Results

Add a dicomwebproxy example integration called kheops.js, and fix the URL call so it works.

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit f621fba
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66cca3c595ee53000765a87a
😎 Deploy Preview https://deploy-preview-4345--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit f621fba
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66cca3c56e2bde0008e25307
😎 Deploy Preview https://deploy-preview-4345--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wayfarer3130
Copy link
Contributor Author

@bradenjmorley - you can use this branch with:
set APP_CONFIG=config/kheops.js
yarn start
to run a kheops compatible server.

Copy link

cypress bot commented Aug 26, 2024

Viewers    Run #4233

Run Properties:  status check passed Passed #4233  •  git commit f621fba31c: Add kheops integration into OHIF v3 again
Project Viewers
Branch Review fix/kheops-url-access
Run status status check passed Passed #4233
Run duration 02m 51s
Commit git commit f621fba31c: Add kheops integration into OHIF v3 again
Committer Bill Wallace
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 44
View all changes introduced in this branch ↗︎

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sedghi sedghi merged commit e1feffa into master Sep 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants