-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tmtv): prevent fusion row in tmtv from getting inverted unexpectedly #4420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viewers Run #4366
Run Properties:
|
Project |
Viewers
|
Run status |
Failed #4366
|
Run duration | 03m 05s |
Commit |
896cde2b61: Merge branch 'master' into fix/inverted-fusion-viewports-tmtv
|
Committer | Ibrahim |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
2
|
Flaky |
0
|
Pending |
2
|
Skipped |
0
|
Passing |
42
|
Tests for review
HangingProtocol.spec.js • 1 failed test
Test | Artifacts | |
---|---|---|
OHIF HP > Should display 3 up |
Test Replay
Screenshots
Video
|
OHIFDoubleClick.spec.js • 1 failed test
Test | Artifacts | |
---|---|---|
OHIF Double Click > Should double click each viewport to one up and back |
Test Replay
Screenshots
Video
|
sedghi
reviewed
Oct 15, 2024
sedghi
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
fixes this bug: