Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tmtv): prevent fusion row in tmtv from getting inverted unexpectedly #4420

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

IbrahimCSAE
Copy link
Collaborator

context

fixes this bug:

CleanShot 2024-10-14 at 14 10 59@2x

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 896cde2
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6711161cc7e7b8000824edef
😎 Deploy Preview https://deploy-preview-4420--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 896cde2
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6711161cc6072100089fb16a
😎 Deploy Preview https://deploy-preview-4420--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Oct 14, 2024

Viewers    Run #4366

Run Properties:  status check failed Failed #4366  •  git commit 896cde2b61: Merge branch 'master' into fix/inverted-fusion-viewports-tmtv
Project Viewers
Run status status check failed Failed #4366
Run duration 03m 05s
Commit git commit 896cde2b61: Merge branch 'master' into fix/inverted-fusion-viewports-tmtv
Committer Ibrahim
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 42

Tests for review

Failed  HangingProtocol.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF HP > Should display 3 up Test Replay Screenshots Video
Failed  OHIFDoubleClick.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Double Click > Should double click each viewport to one up and back Test Replay Screenshots Video

@sedghi sedghi merged commit 33af9bb into master Oct 17, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants