fix(DicomWebDataSource): Enhance QIDO query to disable wildcard for mrn #4435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add an optional `disableWildcard` parameter to the `mapParams` function in `qido.js` - Update the `getStudiesForPatientByMRN` function in `Panels/getStudiesForPatientByMRN.js` to disable wildcard search when querying by patient MRN - This change allows more precise QIDO queries when the data source supports wildcard searches, while providing a way to disable the wildcard behavior when necessary
✅ Deploy Preview for ohif-prod canceled.
|
Viewers
|
||||||||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/mrn-search
|
| Run status |
|
| Run duration | 06m 55s |
| Commit |
|
| Committer | Alireza |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
43
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/integration/ImageConsistency.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| CS3D Image Consistency and Quality > TG18 Resolution Test Displayed 1:1 |
Test Replay
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disableWildcardparameter to themapParamsfunction inqido.jsgetStudiesForPatientByMRNfunction inPanels/getStudiesForPatientByMRN.jsto disable wildcard search when querying by patient MRNContext
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment