Spin lock deadlock detection #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-lms
reviewed
Jul 7, 2017
| { | ||
| unsigned int retries = 0; | ||
| unsigned int reminder = 0; | ||
| assert(thread_foreign_intr_disabled()); |
There was a problem hiding this comment.
minor: empty line before the assert.
| unsigned int retries = 0; | ||
| unsigned int reminder = 0; | ||
|
|
||
| while (!cpu_spin_trylock(&pager_spinlock)) { |
There was a problem hiding this comment.
/* returns 0 on locking success, non zero on failure */
unsigned int __cpu_spin_trylock(unsigned int *lock);
....
static inline bool cpu_spin_trylock(unsigned int *lock)
{
unsigned int rc;
assert(thread_foreign_intr_disabled());
rc = __cpu_spin_trylock(lock);
if (!rc)
spinlock_count_incr();
return !rc;
}
There was a problem hiding this comment.
I don't actually understand why cpu_spin_trylock() == !__cpu_spin_trylock(), which can throw into confusion
There was a problem hiding this comment.
I agree, it is confusing. It stems from strex returning 1 in <Rd> on failure and 0 on success and that __cpu_spin_trylock() tries to do the bare minimum.
The code here is correct though.
|
Review comment addressed |
igoropaniuk
reviewed
Jul 10, 2017
Attempts to detect and report deadlock on spin locks.. Reviewed-by: Igor Opaniuk <[email protected]> Signed-off-by: Jens Wiklander <[email protected]>
Adds more details to deadlock report inside pager. Reviewed-by: Igor Opaniuk <[email protected]> Tested-by: Jens Wiklander <[email protected]> Signed-off-by: Jens Wiklander <[email protected]>
jenswi-linaro
force-pushed
the
spin_lock_deadlock
branch
from
cd87814
to
413a61f
Compare
|
Tag applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.