Asan fix #1799
Merged
Asan fix #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For "core: asan: tag access for .ARM.extab and .ARM.exidx": |
|
for "core: asan: fix check_access() ": |
jenswi-linaro
force-pushed
the
asan_fix
branch
from
59654e0
to
89c7db4
Compare
|
Tags applied |
|
I have test this patch with xtest, and it resolves the problem i mentioned in #1790 , but i got another problem, this is my error message: It have applied the latest @jenswi-linaro Only runs the gp_8060 can't reproduce the problem, i must run xtest all to produce this error, so i guess maybe some branch code of the calloc can't deal with asan very well. |
|
@prime-zeng I have mistakenly inserted an extra 'x' in the stack dump. Fixed in #1802. Thanks for reporting! |
|
I got a slightly different call stack when testing this PR on QEMU ( Hangs there, secure console shows a panic which decodes to: |
|
A slightly different stack still in |
|
Added two commits that should fix the problem reported. These two commits should be reordered first before merging this PR. |
|
For the 3 first For the last: |
|
@etienne-lms , bget() tags the requested amount of memory allocated, but eventual padding etc isn't tagged so writes there from instrumented functions (for instance the normal memset()) will be caught. |
|
Crystal clear, thanks. |
jenswi-linaro
force-pushed
the
asan_fix
branch
from
3f9995e
to
121e56f
Compare
|
Tags applied, commits reordered. |
|
By the way, would you mind adding your explanation
into the commit comment? |
jenswi-linaro
force-pushed
the
asan_fix
branch
from
121e56f
to
12fd77a
Compare
|
commit message amended. |
|
It looks like |
Provides asan_memset_unchecked() which does a memset that isn't checked against the tagging in the ASAN shadow area. If ASAN isn't enabled it's replaced by a direct call to memset(). Reviewed-by: Etienne Carriere <[email protected]> Signed-off-by: Jens Wiklander <[email protected]>
The malloc implementation uses the new asan_memset_unchecked() function internally instead of memset() to avoid unexpected asserts when the address sanitizer is enabled. bget() tags the requested amount of memory allocated, but eventual padding etc isn't tagged so writes there from instrumented functions, for instance the normal memset(), will be caught. Reviewed-by: Etienne Carriere <[email protected]> Signed-off-by: Jens Wiklander <[email protected]>
Prior to this patch the for loop in check_access() that checks the access in the shadow area is skipping accesses smaller than a ASAN block (8 bytes). This patch fixes that problem and checks also smaller accesses. Reviewed-by: Etienne Carriere <[email protected]> Signed-off-by: Jens Wiklander <[email protected]>
The two sections .ARM.extab and .ARM.exidx are accessed when printing a stack trace. Tag access for these two sections to avoid recursive panics due to failing checks against shadow area. Tested-by: Jens Wiklander <[email protected]> (QEMU) Reviewed-by: Etienne Carriere <[email protected]> Reviewed-by: Jerome Forissier <[email protected]> Signed-off-by: Jens Wiklander <[email protected]>
jenswi-linaro
force-pushed
the
asan_fix
branch
from
12fd77a
to
5811b26
Compare
|
|
|
The remaining build failures are caused by 6a815af ("core: introduce TEE_RAM_VA_START and TEE_TEXT_VA_START"). So I'm merging this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.