From ec15c258395f29acfcc100416a06ac489358fede Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Edouard=20Choini=C3=A8re?=
 <27212526+echoix@users.noreply.github.com>
Date: Sat, 5 Oct 2024 18:01:07 +0000
Subject: [PATCH] style Fix unnecessary-list-comprehension-dict (C404)

Rewrites unnecessary `list` comprehension as a `dict` comprehensions.

Ruff rule: https://docs.astral.sh/ruff/rules/unnecessary-list-comprehension-dict/
---
 pyproject.toml                                | 1 -
 python/grass/pydispatch/robustapply.py        | 2 +-
 python/grass/pygrass/modules/grid/grid.py     | 6 ++----
 python/grass/pygrass/modules/interface/env.py | 9 +++------
 utils/g.html2man/ghtml.py                     | 2 +-
 5 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/pyproject.toml b/pyproject.toml
index 18dbdd75067..04b0276bece 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -98,7 +98,6 @@ ignore = [
     "B904",    # raise-without-from-inside-except
     "B909",    # loop-iterator-mutation
     "BLE001",  # blind-except
-    "C404",    # unnecessary-list-comprehension-dict
     "C414",    # unnecessary-double-cast-or-process
     "C416",    # unnecessary-comprehension
     "COM812",  # missing-trailing-comma
diff --git a/python/grass/pydispatch/robustapply.py b/python/grass/pydispatch/robustapply.py
index a050f54341a..cd52f74c22e 100644
--- a/python/grass/pydispatch/robustapply.py
+++ b/python/grass/pydispatch/robustapply.py
@@ -86,5 +86,5 @@ def robustApply(receiver, *arguments, **named):
         )
         # fc does not have a **kwds type parameter, therefore
         # remove unacceptable arguments.
-        named = dict([(k, v) for k, v in named.items() if k in acceptable])
+        named = {k: v for k, v in named.items() if k in acceptable}
     return receiver(*arguments, **named)
diff --git a/python/grass/pygrass/modules/grid/grid.py b/python/grass/pygrass/modules/grid/grid.py
index e0dbd309656..661d5a3df64 100644
--- a/python/grass/pygrass/modules/grid/grid.py
+++ b/python/grass/pygrass/modules/grid/grid.py
@@ -122,9 +122,7 @@ def read_gisrc(gisrc):
     True
     """
     with open(gisrc) as gfile:
-        gis = dict(
-            [(k.strip(), v.strip()) for k, v in [row.split(":", 1) for row in gfile]]
-        )
+        gis = {k.strip(): v.strip() for k, v in [row.split(":", 1) for row in gfile]}
     return gis["MAPSET"], gis["LOCATION_NAME"], gis["GISDBASE"]
 
 
@@ -603,7 +601,7 @@ def get_works(self):
                         indx = row * cols + col
                         inms[key] = "%s@%s" % (self.inlist[key][indx], self.mset.name)
                 # set the computational region, prepare the region parameters
-                bbox = dict([(k[0], str(v)) for k, v in box.items()[:-2]])
+                bbox = {k[0]: str(v) for k, v in box.items()[:-2]}
                 bbox["nsres"] = "%f" % reg.nsres
                 bbox["ewres"] = "%f" % reg.ewres
                 new_mset = (
diff --git a/python/grass/pygrass/modules/interface/env.py b/python/grass/pygrass/modules/interface/env.py
index 1f0519d23c5..d3d6e371238 100644
--- a/python/grass/pygrass/modules/interface/env.py
+++ b/python/grass/pygrass/modules/interface/env.py
@@ -14,12 +14,9 @@ def get_env():
     if gisrc is None:
         raise RuntimeError("You are not in a GRASS session, GISRC not found.")
     with open(gisrc) as grc:
-        return dict(
-            [
-                (k.strip(), v.strip())
-                for k, v in [row.split(":", 1) for row in grc if row]
-            ]
-        )
+        return {
+            k.strip(): v.strip() for k, v in [row.split(":", 1) for row in grc if row]
+        }
 
 
 def get_debug_level():
diff --git a/utils/g.html2man/ghtml.py b/utils/g.html2man/ghtml.py
index eabb494198d..1a36fd3af06 100644
--- a/utils/g.html2man/ghtml.py
+++ b/utils/g.html2man/ghtml.py
@@ -95,7 +95,7 @@
 
 
 def setify(d):
-    return dict([(key, frozenset(val)) for key, val in d.items()])
+    return {key: frozenset(val) for key, val in d.items()}
 
 
 def omit(allowed, tags):