Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert shader reading code from C-style to C++ iostreams #7

Open
rpavlik opened this issue Feb 20, 2015 · 2 comments
Open

Convert shader reading code from C-style to C++ iostreams #7

rpavlik opened this issue Feb 20, 2015 · 2 comments

Comments

@rpavlik
Copy link
Member

rpavlik commented Feb 20, 2015

https://github.com/sensics/distortionizer/blob/master/shaders/undistort_shader.cpp#L94

I will refrain from passing judgement, recognizing that people are familiar with different things 😄 , just acknowledge that the code there can be made better or at least more idiomatic.

I can do it pretty quickly, if I get a chance (it's a handful of lines tops), though I'm not sure when that gets invoked so I'm not sure I'd be able to confidently say I didn't break it.

cc @russell-taylor

@russell-taylor
Copy link
Contributor

Thanks for pointing this out. Step 1: Copy-paste from an existing project. Step 2: Hand off code that is halfway written before I've had the chance to check and clean up.

The same excuse won't work for VRPN, of course. Looking forward to using standard libraries there as well. You can assign this to me if you want, but I won't get to it until after the latency is licked.

@rpavlik
Copy link
Member Author

rpavlik commented Feb 20, 2015

LOL, no worries, I totally get the "hand off partially finished tool" thing. Just wanted to put this into the issue tracker while I was doing the same with other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants