Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New threat by type/context throws error on edges #1110

Closed
lreading opened this issue Oct 11, 2024 · 4 comments · Fixed by #1120
Closed

New threat by type/context throws error on edges #1110

lreading opened this issue Oct 11, 2024 · 4 comments · Fixed by #1120
Assignees
Labels
bug Something isn't working priority version-2.3
Milestone

Comments

@lreading
Copy link
Collaborator

Describe the bug:
New threat by type and new threat by context throw an error when using them on an edge. The new threat button is disabled, so I suspect this is an unintended workflow.

Expected behaviour:
Should we disable these buttons when the "New Threat" button is disabled? I'm not sure how this is used.

Environment:

  • Version: 2.2.0-latest
  • Platform: Web App
  • OS: Ubuntu 24.04
  • Browser: Vivaldi (chromium based)

To Reproduce:

  1. Create a new Diagram
  2. Add a trust boundary curve
  3. Select the edge (tb curve)
  4. Click either "New Threat By Type" or "New Threat By Context"
  5. Attempt to save
  6. Threat is not saved, and there are errors in the console

image

Any additional context, screenshots, etc:

@lreading lreading added the bug Something isn't working label Oct 11, 2024
@jgadsden
Copy link
Collaborator

good point - the new threat button is disabled for an out of scope component or no component selected
we can disable the threats by context / type along with the new threat button

@Gauravsinghrajputt
Copy link

assign me for this issues

@lreading
Copy link
Collaborator Author

Awesome, thanks @Gauravsinghrajputt !

@jgadsden jgadsden self-assigned this Oct 16, 2024
@jgadsden
Copy link
Collaborator

taking this on as we need it for the version 2.3 release this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority version-2.3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants