Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Remove scripts from repo #4880

Closed
foosel opened this issue Aug 29, 2023 · 3 comments
Closed

[Request] Remove scripts from repo #4880

foosel opened this issue Aug 29, 2023 · 3 comments
Labels
done Done but not yet released request Feature request
Milestone

Comments

@foosel
Copy link
Member

foosel commented Aug 29, 2023

Is your feature request related to a problem? Please describe.

There's a bunch of init scripts for sysv and systemd located in the source tree under scripts. That stuff hasn't really been maintained over the years, and while the systemd sample is still totally fine, just like the outdated sysv one it still relies on an installation into a venv in a user's home when best practice would actually be to create a dedicated user and application folder somewhere under /opt or similar.

Describe the solution you'd like

Get rid of this stuff and have deployment information rather live in the docs or if needed in a dedicated repo.

Does anyone see any issue with that? Am I overlooking problems for any of the third party installer scripts that might be utilizing these files (@paukstelis maybe)?

Describe alternatives you've considered

No response

Additional context

No response

@foosel foosel added the request Feature request label Aug 29, 2023
@foosel foosel added this to the 1.10.0 milestone Aug 29, 2023
@cp2004
Copy link
Member

cp2004 commented Aug 29, 2023

The install guides on the forums have the user wget these files to use them in their install - that could change, but wanted to point out that as a reference.

@paukstelis
Copy link

No impact on octoprint_deploy.

@foosel
Copy link
Member Author

foosel commented Nov 20, 2023

Adjusted the install guide and got rid of the files. Will be gone in 1.10.0.

@foosel foosel added the done Done but not yet released label Nov 20, 2023
@foosel foosel closed this as completed in bfd7199 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Done but not yet released request Feature request
Projects
Status: Done
Development

No branches or pull requests

3 participants