Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achievements plugin: unsupported format character 'Z' (0x5a) at index 93 #5017

Closed
3 of 4 tasks
armybean opened this issue May 21, 2024 · 5 comments
Closed
3 of 4 tasks
Labels
bug Issue describes a bug done Done but not yet released
Milestone

Comments

@armybean
Copy link

The problem

When I open the achievements plugin, I get this error:

There was an error with the template dialogs/about.jinja2 at line number 48: unsupported format character 'Z' (0x5a) at index 93

This appears since I updated to 1.10.1 - in 1.10.0 it was possible to open the achievements page as normal.

Did the issue persist even in safe mode?

Yes, it did persist

If you could not test in safe mode, please state why ("currently printing" is NOT an excuse!)

No response

Version of OctoPrint

OctoPrint 1.10.1

Operating system running OctoPrint

OctoPi* 1.0.0cam (build 2023.10.09.154319)

Printer model & used firmware incl. version

Prusa MK3S+ MMU3 version 3.13.2

Browser and version of browser, operating system running browser

Brave 1.65.132 on macOS Monterey 12.7.4

Checklist of files to include below

  • Systeminfo Bundle (always include!)
  • Contents of the JavaScript browser console (always include in cases of issues with the user interface)
  • Screenshots and/or videos showing the problem (always include in case of issues with the user interface)
  • GCODE file with which to reproduce (always include in case of issues with GCODE analysis or printing behaviour)

Additional information & file uploads

octoprint-systeminfo-20240521110043.zip
Screenshot 21 05 2024 um 11 03 35 AM

@github-actions github-actions bot added the triage This issue needs triage label May 21, 2024
@foosel
Copy link
Member

foosel commented May 21, 2024

This seems to be an issue with german translation, does it stop to reproduce when you switch it to english? (Can be done in the User Settings or globally in the Appearance Settings)

@foosel foosel added bug Issue describes a bug and removed triage This issue needs triage labels May 21, 2024
@foosel foosel added this to the 1.10.x milestone May 21, 2024
@foosel
Copy link
Member

foosel commented May 21, 2024

Just confirmed that this only happens with the (bundled) german translation, so it must be something in there.

@armybean
Copy link
Author

Maybe here:
OctoPrint/translations/de/LC_MESSAGES/messages.po (beginning line 300)

#: src/octoprint/plugins/achievements/templates/achievements_about_achievements.jinja2:6
#, python-format
msgid ""
"Achievements with a %(clock)s are time based and rely on proper "
"%(startlink)stimezone configuration%(endlink)s (currently: %(timezone)s, "
"%(time)s)."
msgstr ""
"Achievements mit einem %(clock)s sind zeitbasiert und hängen von einer "
"korrekten %(startlink)Zeitzonen-Konfiguration%(endlink) ab (aktuell: "
"%(timezone)s, %(time)s)."

In the English part there is %(startlink)s and %(endlink)s where in German translation there is the "s" missing.

@foosel
Copy link
Member

foosel commented May 21, 2024

Yes, already spotted and committed the fix, it was just not yet pushed. Will go out with 1.10.2, but I'm not yet sure when I'll be able to push that out, would prefer to wait until next week at least in case anything else shows up than the two things I already know about now, as a bugfix release just for this is a ton of overhead for something that can be solved by switching the language (or attaching ?l10n=en to the URL), and is not in a mission critical part of the software.

@foosel foosel added the done Done but not yet released label May 21, 2024
@GitIssueBot
Copy link

This issue has been mentioned on OctoPrint Community Forum. There might be relevant details there:

https://community.octoprint.org/t/achievements-shows-error/58479/11

@foosel foosel closed this as completed in 522e4c8 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue describes a bug done Done but not yet released
Projects
Status: Done
Development

No branches or pull requests

3 participants