Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Improve preview of files using "scarf joint seam" (orcaslicer & others) #5039

Open
jepler opened this issue Jul 5, 2024 · 3 comments
Labels
request Feature request

Comments

@jepler
Copy link

jepler commented Jul 5, 2024

Is your feature request related to a problem? Please describe.

I've recently started to use the "scarf joint seam" feature of orcaslicer, which can improve the surface finish of many 3d prints.

However, this feature emits XYZE moves which confuse the gcode preview in octoprint, making it report an incorrect number of layers, as well as making the layer-by-layer preview not useful.

Describe the solution you'd like

Octoprint needs to use a different method to analyze gcode files that use scarf join. However, I don't know enough about the internals to have a concrete suggestion.

Describe alternatives you've considered

Many slicers emit special comments to delimit the slicer's idea of a layer. Octoprint could (optionally?) look for these in lieu of what it appears to do now, analyze the Z-heights where extrusion takes place.

Additional context

Reproducer gcode:

benchy-gcode.zip

I can provide a gcode file reproducer if needed. I'm using OrcaSlicer 2.1.1 on Linux.

This might also improve gcode visualization of vase mode prints, as well.

@github-actions github-actions bot added the request Feature request label Jul 5, 2024
@jneilliii
Copy link
Contributor

This is an interesting challenge. I know @JoveToo was one of the last contributors to the GCode Viewer, wonder if he might have some ideas.

@JoveToo
Copy link
Contributor

JoveToo commented Jul 5, 2024

Please upload a gcode file from a benchie or something with scarf joint seam.

I will take a look.

@jepler
Copy link
Author

jepler commented Jul 5, 2024

I've updated the initial comment with a zipped gcode file that demonstrated the problem.

Model size: 154.79mm × 123.30mm × 48.00mm
Estimated layer height: 0.00mm
Estimated total print time: 00:49:52
Layers with extrusion: 13327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Feature request
Projects
Status: Todo
Development

No branches or pull requests

3 participants