Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HalibutRuntime extension/inheritance #435

Open
Discolai opened this issue Aug 16, 2023 · 0 comments
Open

HalibutRuntime extension/inheritance #435

Discolai opened this issue Aug 16, 2023 · 0 comments

Comments

@Discolai
Copy link

Our team is looking into integrating a Halibut server into an existing Asp Net application. The hosting model of this application is a bit restrictive so we would like to use the existing iis server if possible. I have created a fork and tested accepting websockets from the Asp Net Owin pipeline, but I would like to keep Halibut updated without maintaining a fork.

Would you consider changing the internal HalibutRuntime ctor, ExchangeProtocolBuilder, HandleMessage, HandleMessageAsync to protected? Then I could simply inherit the HalibutRuntime class and maintain type safety. I could work around this by using reflection, but that seems a bit to brittle for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant