Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New items highlighting issues #63

Open
RobWed opened this issue Nov 26, 2021 · 4 comments
Open

New items highlighting issues #63

RobWed opened this issue Nov 26, 2021 · 4 comments

Comments

@RobWed
Copy link

RobWed commented Nov 26, 2021

Hi Odie,

I notice that the new items function has some quirks, the upshot of which is that inventory management gets more complicated.

  1. If you have existing items they are rolled into the new. Not really a problem...
  2. If you have less than 6 items and move 2 out of inventory, the rest are unflagged and move below the sorting for new. Annoying when you want to move the whole stack. I had to learn to move 2 then stop to check the next item on the list.
  3. Sometimes, moving an item not flagged as new causes the rest of the stack to be flagged as new.

It strikes me as similar to the way stolen items are flagged. It seems like individual items in a stack get flagged (or not) and the status of the stack is the status of the top item.

Like so:
item (new)
item
item (stolen)
item
item (stolen)

so the stack is initially flagged as new, the first two items get moved out of inventory and the stack is resorted below all the new items. Then the stack is flagged as stolen. Moved the top item out and the stack is not flagged. Move the next item out and the remaining one is flagged as stolen. This is just my observation from playing. No actual idea what is going on with the game mechanic.

@Odie
Copy link
Owner

Odie commented Nov 27, 2021

Hi there!

I think all of this is caused by the simplistic way the feature was implemented. It really doesn't deal with individual items.

  1. If you have existing items they are rolled into the new.

When an item has entered the player inventory, it takes note of the item's FormID. When displaying the inventory, anything with that same FormID is considered new. If you have a stack of iron arrows and you pick up 1 more, the entire stack will be shown as "new". There are places where this simplistic scheme doesn't quite work right though. For example, if you have an enchanted ebony sword in the inventory, and you pick up a vanilla one, both will show up as "new" since they have the same FormID.

Will have to do a bit more homework to see how to address that one.

  1. If you have less than 6 items and move 2 out of inventory, the rest are unflagged and move below the sorting for new.

When an item has exited the player inventory, the "new" flag on that FormID gets cleaned up. This basically means "all items of this type is now considered not new".

I should be able to fix this just by not cleaning up the flag when there are more items of that type in the inventory.

  1. Sometimes, moving an item not flagged as new causes the rest of the stack to be flagged as new.

Even if you're retrieving something from a player owned container, the item would still be marked "new" as soon as it entered the player inventory. Is this something you find not helpful?

@RobWed
Copy link
Author

RobWed commented Nov 30, 2021

Thanks Odie

First point understood. That's fine. Second point is just minor.

Third point is different. I noticed that things are new based on their entry into the current container. That's fine. I'm talking about items in the current container that are not flagged as new. After moving 2 of them out of the container, the rest get flagged as new and get moved to the top of the list. This is a bit of a pita as it means having to scroll to the top of the list in order to move the rest. Again it only happens in the 3-5 item range.

Definitely not critical

@caboose684
Copy link

caboose684 commented Jan 1, 2022

Could you add an option to toggle this sorting behavior? I prefer it only sort by the column I have selected.

Not adding or clearing the "new" flag during a single inventory session would also be very helpful. I find a single item moving to a new spot in the list while trying to interact with that item is a confusing behavior, especially because it doesn't stay selected. It seems counterintuitive to select a stack of 3 items in a chest, quickly hit the button three times, and get two of that item and one of the next because the selection changed when the first item sorted to the top.

I agree this isn't critical. It works great otherwise and these are easily worked around.

@caboose684
Copy link

In case anyone else is looking for a workaround, you can disable the new items sorted to the top by editing the file "SkyrimVR\Data\Interface\skyui\config.txt" and removing newItem, from the sortAttributes lines throughout the ITEM NAME COLUMN section that starts on line 117.

The lines

columns.itemNameColumn.state1.sortAttributes = <newItem, text>
columns.itemNameColumn.state2.sortAttributes = <newItem, isEquipped, equipState, text>
columns.itemNameColumn.state3.sortAttributes = <newItem, isStolen, text>
columns.itemNameColumn.state4.sortAttributes = <newItem, isEnchanted, text>

should be changed to

columns.itemNameColumn.state1.sortAttributes = <text>
columns.itemNameColumn.state2.sortAttributes = <isEquipped, equipState, text>
columns.itemNameColumn.state3.sortAttributes = <isStolen, text>
columns.itemNameColumn.state4.sortAttributes = <isEnchanted, text>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants