Role uses deprecated keyring.gpg

[hydrian]

Role fails because the task uses apt_key and adds it to the default keyring. Now extra repositories should use their own keyring and reference it the .list file

[tersmitten]

I don't see anything failing

[tersmitten]

But I agree that using "your own keyring" is the way to go (nowadays).

[tersmitten]

But:

Adding a key to /etc/apt/trusted.gpg.d is insecure because it adds the key for all repositories. This is exactly why apt-key had to be deprecated.

[tersmitten]

See https://github.com/Oefenweb/ansible-vagrant

[hydrian]

Adding a key to /etc/apt/trusted.gpg.d is insecure because it adds the key for all repositories. This is exactly why apt-key had to be deprecated.

I know that /etc/apt/trusted.gpg.d isn't trused. It was a typo. The PR has been updated to use /etc/apt/keyrings.

[tersmitten]

I prefer consistency (because we have so many roles), can you make it just like the vagrant role?

[hydrian]

I'll look into it. Not very familiar with vagrant.