Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no detail error message when botAadApp/create failed #8910

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

blackchoey
Copy link
Contributor

@blackchoey blackchoey commented Jun 2, 2023

@blackchoey
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #8910 (4667859) into hotfix/5.0.1 (eb00c84) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 4667859 differs from pull request most recent head d4187d7. Consider uploading reports for the commit d4187d7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           hotfix/5.0.1    #8910      +/-   ##
================================================
+ Coverage         78.92%   78.94%   +0.01%     
================================================
  Files               609      609              
  Lines             42156    42158       +2     
  Branches           8386     8387       +1     
================================================
+ Hits              33273    33280       +7     
  Misses             5520     5520              
+ Partials           3363     3358       -5     
Impacted Files Coverage Δ
...s/fx-core/src/component/driver/botAadApp/create.ts 90.24% <100.00%> (+0.24%) ⬆️

... and 2 files with indirect coverage changes

@adashen adashen merged commit 4375db5 into hotfix/5.0.1 Jun 5, 2023
@wenytang-ms wenytang-ms deleted the chyuan/detail-error-message-for-bot branch June 6, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants