Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add await for creating gitignore #8912

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

xzf0587
Copy link
Contributor

@xzf0587 xzf0587 commented Jun 2, 2023

Fix: https://dev.azure.com/msazure/Microsoft%20Teams%20Extensibility/_workitems/edit/23537793
The bug of project-id missing in telemetry is fixed in #8907

blackchoey
blackchoey previously approved these changes Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #8912 (586d7a1) into hotfix/5.0.1 (4375db5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           hotfix/5.0.1    #8912   +/-   ##
=============================================
  Coverage         78.93%   78.93%           
=============================================
  Files               609      609           
  Lines             42158    42158           
  Branches           8387     8387           
=============================================
+ Hits              33277    33279    +2     
+ Misses             5520     5519    -1     
+ Partials           3361     3360    -1     
Impacted Files Coverage Δ
...s/fx-core/src/core/middleware/projectMigratorV3.ts 88.47% <100.00%> (+0.53%) ⬆️

@adashen adashen merged commit 4ea9bbf into hotfix/5.0.1 Jun 7, 2023
@xzf0587 xzf0587 deleted the zhaofeng/upgrade/gitignore branch June 7, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants