Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading a sample doesn't check if the api_set is supported #953

Open
AlexJerabek opened this issue Jul 5, 2022 · 1 comment
Open

Loading a sample doesn't check if the api_set is supported #953

AlexJerabek opened this issue Jul 5, 2022 · 1 comment

Comments

@AlexJerabek
Copy link
Collaborator

Bug Report

  • Host: N/A
  • OS: N/A
  • Browser: N/A
  • Environment: prod

Expected behavior:

Loading a sample marked as a higher requirement set than supported (using the api_set key) should fail.

Actual behavior:

Samples with unsupported features are successfully loaded. It should only be noted that the call to isSetSupported in Script Lab is using the deprecated variant that takes in a number instead of a string. This means won't behave correctly with requirement sets like ExcelApi 1.10. There's also no consideration for online-only requirement sets, like ExcelOnlineApi 1.1.

Steps to Reproduce:

  1. Load the "Track changes" sample in Word on Windows (it uses online-only API and is marked as 1.4; Word on Windows only supports up to 1.3)

Screenshot:

What happens:
a055d04d-fab4-428f-9721-efa55df94f97

What should happen:
8b12b77d-05ad-4bf9-afde-9eab2b0c2322

@chenxizhang
Copy link

chenxizhang commented Sep 4, 2022

Good point. Per my understanding, it's better to always check the API set in our code...

Zero-trust 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants