Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseUrl (sometimes) not honored when loading images/default_tv_poster.png #4792

Closed
BowlesCR opened this issue Nov 4, 2022 · 2 comments
Closed

Comments

@BowlesCR
Copy link

BowlesCR commented Nov 4, 2022

Describe the bug
References to the default tv/movie (and probably music) poster image don't include the baseUrl correctly, causing them to 404 when served via reverse-proxy.

Oddly, it seems to eventually work correctly after several retries. My SWAG is some kind of race condition preventing proper initialization of baseUrl near this bit of code...

constructor(@Inject(APP_BASE_HREF) private href: string) {

To Reproduce
Steps to reproduce the behavior:

  1. Discover page
  2. Open developer console
  3. Scroll Upcoming section until an item appears without a poster image
  4. Observe repeated 404 attempts to load from /images/ instead of /<baseUrl>/images/ before eventually loading the correct URL.
  5. Continuing to scroll will eventually trigger the same issue again.

Expected behavior
Properly honor the baseUrl setting

Desktop (please complete the following information):

  • OS: Linux (Fedora 37) - Firefox 105

Ombi Version (please complete the following information):

  • Version: 4.29.2
  • Media Server: Emby 4.8.0.16
  • Database Type: MariaDB

Additional context
Nginx configured as reverse proxy with /ombi/ baseUrl. Nginx, Ombi, and Emby are all Docker containers on the same host.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Hi!

Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.

Have you looked at the wiki yet? https://docs.ombi.app/

Before posting make sure you also read our FAQ.

Make the title describe your issue. Having 'not working' or 'I get this bug' for 100 issues, isn't really helpful.

If we need more information or there is some progress we tag the issue or update the tag and keep you updated.

Thanks!

Ombi Bot.

@sephrat
Copy link
Contributor

sephrat commented May 17, 2023

This was later reported as #4845 and fixed subsequently.

@sephrat sephrat closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants