Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hook to custom interface or IPloneSiteRoot, not INavigationRoot #156

Open
petri opened this issue Oct 27, 2014 · 2 comments
Open

hook to custom interface or IPloneSiteRoot, not INavigationRoot #156

petri opened this issue Oct 27, 2014 · 2 comments

Comments

@petri
Copy link

petri commented Oct 27, 2014

Hooking the logo to INavigationRoot breaks other add-ons that use INavigationRoot: For example, if I wish to use INavigationRoot for some other purpose, while using plonetheme.onegov, I get the onegov logo on all other INavigationRoots as well by default.
@maethu
Copy link
Member

maethu commented Oct 27, 2014

Is the logo the only problem? If so, it would be better to implement a better logo behavior, which gets the logo from IPloneSiteRoot and not the default onegov logo on a INavigationRoot.

@petri
Copy link
Author

petri commented Oct 27, 2014

I don't know of other issues. This happens on plain-vanilla Plone as well BTW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petri @maethu