[Bug]: ConcurrentModificationException at initializeFromModel in production #1850

fanwgwg · 2023-09-24T07:44:16Z

What happened?

From user crash logs, we're seeing quite a few ConcurrentModificationException from OneSignal's initializeFromModel method

Stacktrace:

Fatal Exception: java.util.ConcurrentModificationException:
       at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:757)
       at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:790)
       at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:788)
       at com.onesignal.common.modeling.Model.initializeFromModel(Model.kt:123)
       at com.onesignal.core.internal.config.impl.ConfigModelStoreListener$fetchParams$1.invokeSuspend(ConfigModelStoreListener.kt:69)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
       at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:33)
       at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:102)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
       at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
       at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:284)
       at kotlinx.coroutines.BlockingCoroutine.joinBlocking(BlockingCoroutine.java:85)
       at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(BuildersKt__Builders.kt:59)
       at kotlinx.coroutines.BuildersKt.runBlocking(Builders.kt:1)
       at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(BuildersKt__Builders.kt:38)
       at kotlinx.coroutines.BuildersKt.runBlocking$default(Builders.kt:1)
       at com.onesignal.common.threading.ThreadUtilsKt$suspendifyOnThread$1.invoke(ThreadUtils.kt:60)
       at com.onesignal.common.threading.ThreadUtilsKt$suspendifyOnThread$1.invoke(ThreadUtils.kt:59)
       at kotlin.concurrent.ThreadsKt$thread$thread$1.run(Threads.kt:30)

Steps to reproduce?

Not sure how to reproduce, here's

What did you expect to happen?

Should not crash

OneSignal Android SDK version

5.0.1

Android version

13

Specific Android models

No response

Relevant log output

No response

Code of Conduct

I agree to follow this project's Code of Conduct

The text was updated successfully, but these errors were encountered:

michael-winkler · 2023-09-24T09:05:31Z

Is this issue not the same as #1820 ?

emawby · 2023-09-25T18:32:11Z

@fanwgwg Thank you for reporting this issue is likely fixed by #1849 and will be released ASAP!

jkasten2 · 2023-09-29T20:56:22Z

OneSignal-Android-SDK 5.0.2 was released with the PR noted above. Let us know if that fixes this issue for you or if it continue to happen.

Neferetheka · 2023-10-05T12:43:19Z

@jkasten2 Can confirm this still happens in V5.0.2 (using the Unity SDK)

fanwgwg · 2023-10-05T13:09:49Z

+1 Still happening in V5.0.2 Android SDK

Neferetheka · 2023-10-05T13:15:00Z

One note, for those using the Unity SDK. It appears Unity V5.0.2 actually uses the Android SDK V5.0.1. So I'm actually not quite sure the bug still happens if you have the latest Android release.

fanwgwg · 2023-10-05T13:18:45Z

We have the same exception being reported by Crashlytics on our latest release that was shipped with OneSignal's 5.0.2

SuperBuper · 2023-10-06T13:30:53Z

The same issue is on Android 12, 13 with OneSigna 5.0.2
Fatal Exception: java.util.ConcurrentModificationException
com.onesignal.common.modeling.Model.initializeFromModel (Model.kt:124)

nan-li · 2023-10-06T19:19:28Z

Hi all, @SuperBuper @fanwgwg thanks for letting us know the latest Android SDK version 5.0.2 did not resolve this crash.

Can you provide updated logs? We want to confirm they are exactly the same.

fanwgwg · 2023-10-07T07:17:21Z

@nan-li Here's the crash log from 5.0.2

Fatal Exception: java.util.ConcurrentModificationException:
       at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:757)
       at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:790)
       at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:788)
       at com.onesignal.common.modeling.Model.initializeFromModel(Model.kt:124)
       at com.onesignal.core.internal.config.impl.ConfigModelStoreListener$fetchParams$1.invokeSuspend(ConfigModelStoreListener.kt:69)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
       at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:33)
       at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:102)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
       at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
       at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:284)
       at kotlinx.coroutines.BlockingCoroutine.joinBlocking(BlockingCoroutine.java:85)
       at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(BuildersKt__Builders.kt:59)
       at kotlinx.coroutines.BuildersKt.runBlocking(Builders.kt:1)
       at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(BuildersKt__Builders.kt:38)
       at kotlinx.coroutines.BuildersKt.runBlocking$default(Builders.kt:1)
       at com.onesignal.common.threading.ThreadUtilsKt$suspendifyOnThread$1.invoke(ThreadUtils.kt:60)
       at com.onesignal.common.threading.ThreadUtilsKt$suspendifyOnThread$1.invoke(ThreadUtils.kt:59)
       at kotlin.concurrent.ThreadsKt$thread$thread$1.run(Threads.kt:30)

terreng · 2023-10-10T21:21:06Z

Still an issue. Seeing crashes in production. Android SDK 5.0.2.

Stack trace from Android 7.1.2 device

Fatal Exception: java.util.ConcurrentModificationException:
       at java.util.LinkedHashMap$LinkedHashIterator.nextEntry(LinkedHashMap.java:429)
       at java.util.LinkedHashMap$EntryIterator.next(LinkedHashMap.java:448)
       at java.util.LinkedHashMap$EntryIterator.next(LinkedHashMap.java:448)
       at com.onesignal.common.modeling.Model.initializeFromModel(Model.kt:124)
       at com.onesignal.core.internal.config.impl.ConfigModelStoreListener$fetchParams$1.invokeSuspend(ConfigModelStoreListener.kt:69)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
       at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:33)
       at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:102)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
       at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
       at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:284)
       at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
       at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
       at kotlinx.coroutines.BuildersKt.runBlocking(:1)
       at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
       at kotlinx.coroutines.BuildersKt.runBlocking$default(:1)
       at com.onesignal.common.threading.ThreadUtilsKt$suspendifyOnThread$1.invoke(ThreadUtils.kt:60)
       at com.onesignal.common.threading.ThreadUtilsKt$suspendifyOnThread$1.invoke(ThreadUtils.kt:59)
       at kotlin.concurrent.ThreadsKt$thread$thread$1.run(Thread.kt:30)

Stack trace from Android 12 device

Fatal Exception: java.util.ConcurrentModificationException:
       at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:760)
       at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:792)
       at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:790)
       at com.onesignal.common.modeling.Model.initializeFromModel(Model.kt:124)
       at com.onesignal.core.internal.config.impl.ConfigModelStoreListener$fetchParams$1.invokeSuspend(ConfigModelStoreListener.kt:69)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
       at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:33)
       at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:102)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
       at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
       at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:284)
       at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
       at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
       at kotlinx.coroutines.BuildersKt.runBlocking(:1)
       at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
       at kotlinx.coroutines.BuildersKt.runBlocking$default(:1)
       at com.onesignal.common.threading.ThreadUtilsKt$suspendifyOnThread$1.invoke(ThreadUtils.kt:60)
       at com.onesignal.common.threading.ThreadUtilsKt$suspendifyOnThread$1.invoke(ThreadUtils.kt:59)
       at kotlin.concurrent.ThreadsKt$thread$thread$1.run(Thread.kt:30)

nan-li · 2023-10-12T18:38:20Z

Hi all, I apologize for any delay,

We have identified the cause and are working on the fix for all the methods this crash is reported.

jennantilla · 2023-11-07T20:47:06Z

Hello everyone! Thank you for your patience here. We have introduced a fix for this crash in our latest release, 5.0.4. Please update your SDK and let us know if you are still having any issues.

jennantilla · 2023-11-14T20:34:28Z

Closing out this issue. Please let us know if you are seeing any further occurrences of this exception. Thanks!

ajaybirla-fabzen · 2023-11-18T05:12:21Z

Hi @jennantilla,

We're still facing this issue in the OneSignal Unity SDK for Android v5.0.5.

Caused by java.util.ConcurrentModificationException: at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:760) at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:792) at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:790) at com.onesignal.common.modeling.Model.initializeFromModel(Model.kt:124) at com.onesignal.core.internal.config.impl.ConfigModelStoreListener$fetchParams$1.invokeSuspend(ConfigModelStoreListener.kt:69) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:33) at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:102) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106) at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:284) at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85) at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59) at kotlinx.coroutines.BuildersKt.runBlocking(:1) at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38) at kotlinx.coroutines.BuildersKt.runBlocking$default(:1) at com.onesignal.common.threading.ThreadUtilsKt$suspendifyOnThread$1.invoke(ThreadUtils.kt:60) at com.onesignal.common.threading.ThreadUtilsKt$suspendifyOnThread$1.invoke(ThreadUtils.kt:59) at kotlin.concurrent.ThreadsKt$thread$thread$1.run(Thread.kt:30)

jennantilla · 2023-11-20T20:55:42Z

Thank you for letting us know! We'll investigate this further.

jennantilla · 2023-11-21T19:43:48Z

@ajaybirla-fabzen sorry for missing this--I see you mention Unity SDK specifically, which does not yet have this fix. A release that will incorporate this is in the works and should be ready by next week. You can check releases here. Thanks!

ajaybirla-fabzen · 2023-11-22T08:10:02Z

@jennantilla Thank you for the update.

ajaybirla-fabzen · 2023-12-12T07:37:42Z

Hi @jennantilla,

When can I expect the next Unity SDK update to include this fix?

We're planning an update to our app, and it would be good if this fix was included in the update.

Thanks

emawby linked a pull request Sep 25, 2023 that will close this issue

Fix concurrent modification exception #1849

Merged

18 tasks

jennantilla mentioned this issue Oct 19, 2023

Fix: Add synchronized blocks to prevent ConcurrentModificationException #1876

Merged

18 tasks

jennantilla closed this as completed Nov 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: ConcurrentModificationException at initializeFromModel in production #1850

[Bug]: ConcurrentModificationException at initializeFromModel in production #1850

fanwgwg commented Sep 24, 2023 •

edited by github-actions bot

Loading

michael-winkler commented Sep 24, 2023

emawby commented Sep 25, 2023 •

edited

Loading

jkasten2 commented Sep 29, 2023

Neferetheka commented Oct 5, 2023

fanwgwg commented Oct 5, 2023

Neferetheka commented Oct 5, 2023

fanwgwg commented Oct 5, 2023

SuperBuper commented Oct 6, 2023

nan-li commented Oct 6, 2023

fanwgwg commented Oct 7, 2023

terreng commented Oct 10, 2023

nan-li commented Oct 12, 2023

jennantilla commented Nov 7, 2023

jennantilla commented Nov 14, 2023

ajaybirla-fabzen commented Nov 18, 2023 •

edited

Loading

jennantilla commented Nov 20, 2023

jennantilla commented Nov 21, 2023

ajaybirla-fabzen commented Nov 22, 2023

ajaybirla-fabzen commented Dec 12, 2023

[Bug]: ConcurrentModificationException at initializeFromModel in production #1850

[Bug]: ConcurrentModificationException at initializeFromModel in production #1850

Comments

fanwgwg commented Sep 24, 2023 • edited by github-actions bot Loading

What happened?

Steps to reproduce?

What did you expect to happen?

OneSignal Android SDK version

Android version

Specific Android models

Relevant log output

Code of Conduct

michael-winkler commented Sep 24, 2023

emawby commented Sep 25, 2023 • edited Loading

jkasten2 commented Sep 29, 2023

Neferetheka commented Oct 5, 2023

fanwgwg commented Oct 5, 2023

Neferetheka commented Oct 5, 2023

fanwgwg commented Oct 5, 2023

SuperBuper commented Oct 6, 2023

nan-li commented Oct 6, 2023

fanwgwg commented Oct 7, 2023

terreng commented Oct 10, 2023

nan-li commented Oct 12, 2023

jennantilla commented Nov 7, 2023

jennantilla commented Nov 14, 2023

ajaybirla-fabzen commented Nov 18, 2023 • edited Loading

jennantilla commented Nov 20, 2023

jennantilla commented Nov 21, 2023

ajaybirla-fabzen commented Nov 22, 2023

ajaybirla-fabzen commented Dec 12, 2023

fanwgwg commented Sep 24, 2023 •

edited by github-actions bot

Loading

emawby commented Sep 25, 2023 •

edited

Loading

ajaybirla-fabzen commented Nov 18, 2023 •

edited

Loading