-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Resuming an NSURLSessionTask with nil URL #1325
Comments
Seems to be related to the |
Quote by Apple docs:
So this is definitively a bug. It seems that the SDK is not percent encoding the
And the above string is not a valid URL because it includes the special char: | and it is not escaped For swift, this could be solved by calling this method: addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed) |
@rhdez Thank you for reporting and for the in depth investigation! We will work on a fix for this. To clarify iOS 17 allows this special character in the url but iOS 16 does not? |
@emawby That is right. As the Apple documentation say for iOS 17:
But that was not the default behavior for iOS 16 and below, so I understand this as an SDK bug. Thank you for your reply. Glad to help! |
Agreed thank you for the update |
What happened?
This happens with iOS 16 but in iOS 17. After
OneSignal.login(externalId)
with an existingexternalId
, the session never get updated with the subscription because theOneSignalUser.OSRequestFetchUser
fails with this error:Before this happen, the login tried to POST the
externalId
getting an error:DEBUG: executeIdentifyUserRequest returned error code user-2. Now handling user-2 error response... switch to this user.
Right after this, the above error appears.With iOS 17, right after the user-2 error, the
OneSignalUser.OSRequestFetchUser
returns a success response with the session data.NOTE the
externalId
is something like:auth0|12345676
Steps to reproduce?
What did you expect to happen?
To retrieve the tags from the user with the
externalId
OneSignal iOS SDK version
Release 5.0.1 and 5.0.2
iOS version
16
Specific iOS version
Relevant log output
The text was updated successfully, but these errors were encountered: