Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APNS delegate never fired - incorrect docs. Help not needed #985

Closed
nikitawolfik opened this issue Apr 20, 2020 · 3 comments
Closed

APNS delegate never fired - incorrect docs. Help not needed #985

nikitawolfik opened this issue Apr 20, 2020 · 3 comments

Comments

@nikitawolfik
Copy link

#910 - not it, tried
#880 leads to #503 where is the answer. Apparently, the docs got updated and no longer say to manually add pod 'OneSignal', '>= 2.6.2', '< 3.0' to Podfile

Description:

After following every required step in the installations docs

yarn add react-native-onesignal
cd ios && pod install && cd ..

and then adding required capabilities in Xcode, I was able to initialize the service, but pushToken from onIds was always null and Dashboard always showed APNS delegate never fired error. After traversing issues I found out that former docs included these lines.

That was not really straightforward and should be added back to the documentation.

Environment

Steps to Reproduce Issue:

  1. (your steps here)

Anything else:

(crash stacktraces, as well as any other information here)

@rgomezp
Copy link
Contributor

rgomezp commented Apr 21, 2020

Howdy,
It is in our documentation as you can see here.

@nikitawolfik
Copy link
Author

@rgomezp yeah, it indeed is, but the section starts with this
image
This step is optional but highly recommended. The OneSignalNotificationServiceExtension allows your application (in iOS) to receive rich notifications with images and/or buttons, along with Badges and advanced analytics like Outcomes.

This is the kind of the section you skip when you are going for the quick setup with minimal functionality and I think it shouldn't be marked optional if not following these steps screws the whole notification thing :)

@rgomezp
Copy link
Contributor

rgomezp commented Apr 22, 2020

Thanks for your suggestion. We will try to make this section a bit clearer.

Enjoy!

@rgomezp rgomezp closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants